search

ut-ras / r5-2019

Region 5 2018-2019
MIT License
5 stars 0 forks source link

Vision/tests #31

Closed dimembermatt closed 5 years ago

dimembermatt commented 5 years ago

Description

Added some more tests and cleaned up some naming conflicts.

thetianshuhuang commented 5 years ago

One of the commits removed all submodules (i think you deleted them by accident).

dimembermatt commented 5 years ago

Fixed! (Probably...) ... is it okay if there is a .git at the end of the URLs now?

thetianshuhuang commented 5 years ago

Can you move the test images into a new folder "vision/dbscan/tests"? Yeah there's no problem with the .git as long as it's a submodule

thetianshuhuang commented 5 years ago

in the vision folder - vision/dbscan/tests

dimembermatt commented 5 years ago

Reading is hard... :( Do you want me to remove the entire vision/tests folder from this branch and put a tests subfolder in the dbscan branch?

thetianshuhuang commented 5 years ago

Yeah; since each vision algorithm will have its own tests, we should have something like

vision
    tests (tests for the entire stack)
    dbscan
        tests
        actual code
    convex_hull
        tests
        actual code
    etc
thetianshuhuang commented 5 years ago

oops i mean the folder (it's ok to have a different branch) but being in the same branch definitely makes things easier.

thetianshuhuang commented 5 years ago

Merged with PR #30 (vision/db_scan)