Multiple bitrate support for DASH audio in .mpd manifest

ut0mt8 / nginx-rtmp-module

NGINX-based Media Streaming Server

http://nginx-rtmp.blogspot.com

BSD 2-Clause "Simplified" License

86 stars 32 forks source link

Multiple bitrate support for DASH audio in .mpd manifest #25

Open EeroHeikkinen opened 3 years ago

EeroHeikkinen commented 3 years ago

This update adds support for multiple audio bitrates for DASH manifests.

This seems to otherwise function correctly, but there is one issue: segment timeline chunks get mismatched from actual files written to disk, if some variants have different frame rates than others. Example: WhatsApp Image 2021-05-19 at 22 43 54 Any idea how this could be fixed?

ut0mt8 commented 3 years ago

Hello; thks for your PR. It's been a long time I don't work on this project. Will see if I have the time to re deep dive into my code. btw I understand the functionality but what is the rationale of having multiple bitrate audio as in general it's very "cheap" in term of bp ?

ut0mt8 commented 3 years ago

For the bug it clearly remains me something I had identified in the past. I need to re read the code but I'm wondering if my implementation is not assuming that every chunk of every representation arrives at the same exact time. The "max" keyword should serve to something like this.