utPLSQL / utPLSQL-maven-plugin

Maven plugin for running Unit Tests with utPLSQL v3
Apache License 2.0
13 stars 10 forks source link

Review all parameter names #17

Closed jgarec closed 5 years ago

jgarec commented 6 years ago

In #16, @jgebal asks if "path" parameters should be renamed to something like suitepaths.

I think we should check that all parameters have almost the same names as in the CLI.

jgarec commented 6 years ago

hi @jgebal, here is a comparaison of all parameters :

You asked in #16 if path should be renamed to something like suite_paths. But i think paths.path is consistent with the CLI.

CLI short parameter CLI long parameter maven XML path
-c --color
--failure-exit-code
ignoreFailure
-f --format reporters.reporter.name
-o reporters.reporter.fileOutput
-s reporters.reporter.consoleOutput
-p --path paths.path
-scc --skip-compatibility-check skipCompatibilityCheck
-exclude excludeObject
-include includeObject
-source_path sources.source.directory
-owner not yet implemented
-regex_expression sourcesRegexExpression
-type_mapping not yet implemented
-owner_subexpression sourcesOwnerSubexpression
-type_subexpression sourcesTypeSubexpression
-name_subexpression sourcesNameSubexpression
-test_path tests.test.directory
-regex_expression testsRegexExpression
-type_mapping not yet implemented
-owner_subexpression testsOwnerSubexpression
-type_subexpression testsTypeSubexpression
-name_subexpression testsNameSubexpression
jgebal commented 6 years ago

This is a great mapping. Maybe we should add this to the project's readme? It would be a shame to loose it.

pesse commented 6 years ago

I totally agree: great mapping, awesome work.

jgarec commented 6 years ago

Sure, let's see with @alberto-hernandez if all parameters are ok or if we need to modify some of them. Then we need to add missing parameters (if necessary).

jgarec commented 6 years ago

Added in #18

jgebal commented 5 years ago

Closing as #18 is merged