search

utPLSQL / utPLSQL-maven-plugin

Maven plugin for running Unit Tests with utPLSQL v3
Apache License 2.0
13 stars 10 forks source link

First approach to increase the functionality of the maven plugin #2

Closed alberto-hernandez closed 6 years ago

alberto-hernandez commented 6 years ago

Improved parametrization of the plugin and standarization of the output files of the reporters.

jgebal commented 6 years ago

Have you seen this solution? https://gist.github.com/nochmu/1f640b01a685f3f83a349de2db8a8882

alberto-hernandez commented 6 years ago

Hi Jacek, This is a good approach for the developers of the utplsql package. The main drackback is that every programmer who use it needs the client installed in his local machine. The maven plugin solution is more scalable due to you don't need a install or maintain a local version of the client, even. The developer only has to be worried of writing good PL/SQL code and its tests :)

jgebal commented 6 years ago

Just as you replied I got to think something similar. You need client installed wherever you want to run maven goal. You mean this maven exec config in every project. It's nice complex from user perspective than just using a plugin.

How do you go about requirements for jdbc driver from Oracle?

Should we mention it in the documentation? Can we add this as a dependency, so that users can download the driver within their maven process?

alberto-hernandez commented 6 years ago

The oracle driver dependency is complex to manage because Oracle do not publish neither public or own maven repository. That said, the driver is a transitive dependency that comes from the java-api project so it makes sense that will be be documented in that package.

jgebal commented 6 years ago

Well actually they do publish but it's a private repository so you need to provide credentials. Have a look at readme on API project. In enterprise, you can always provide a private nexus repo with driver in it I think.

jgebal commented 6 years ago

But I agre it's more complicated than it should be

alberto-hernandez commented 6 years ago

The common workaround for this is download the package and installed it in your private maven repository. In my opinion, it is a common solution that programmers are familiar with. If you consider to add the same disclaimer for this driver it is not a problem.

jgebal commented 6 years ago

@alberto-hernandez All looks great. @pesse and me are only concerned of ownership and maintenance burden. Will you be keen and willing to take responsibility for code maintenance, at least for some time, while there are intense changes and project is still fresh and evolving.

To be honest, we're short on hands and need a custodian for this part of project.

alberto-hernandez commented 6 years ago

At least for this year is not a problem to maintain the plugin.

jgebal commented 6 years ago

Can you join our slack at: http: // utplsql-slack-invite.herokuapp.com this is the best way to chat to others and discuss on random topics