search

utPLSQL / utPLSQL-maven-plugin

Maven plugin for running Unit Tests with utPLSQL v3
Apache License 2.0
13 stars 10 forks source link

Embedded the java-api into the plugin jar #41

Closed viniciusam closed 4 years ago

viniciusam commented 5 years ago

The generated artifact will have java-api code embedded and it won't be part of the final pom for the library, that way the users won't need to add the java-api to their private repos. I also added ojdbc as a direct dependency, but I'm not sure if this will fix #23 as I couldn't test it locally.

adrianhj commented 5 years ago

With the license of the Oracle JDBC drivers, are we able to distribute these ourselves and still fit into Apache 2.0? Usual strategy for most products touching an Oracle database I've worked on has been a case of 'end-user needs to provide drivers or it affects our ability to manage our own license' unfortunately.

From my understanding redistribution of the JDBC drivers requires the consumer to agree to certain terms: https://www.oracle.com/technetwork/database/enterprise-edition/jdbc-faq-090281.html#02_12.

Probably safer to treat this as a provided dependency and document that the driver needs to be provided to the plugin (or continue as now and pull it in automatically through the java-api as a dependency in plugin.xml without packaging and including it directly).

pesse commented 5 years ago

Gerald Venzl dug into that about a year ago and his suggestion was to not ship any Oracle binaries or package them.