search

utPLSQL / utPLSQL-maven-plugin

Maven plugin for running Unit Tests with utPLSQL v3
Apache License 2.0
13 stars 10 forks source link

Added tags and random test execution parameters #51

Closed viniciusam closed 4 years ago

viniciusam commented 4 years ago

Fixes #50 #42

jgebal commented 4 years ago

@pesse - any chance for you to review this PR?

jgebal commented 4 years ago

@viniciusam - something odd with sonar reporting - no coverage was reported on this PR. If you look at develop - there was coverage on UtPLSQLMojo.java https://sonarcloud.io/component_measures?id=org.utplsql%3Autplsql-maven-plugin&metric=coverage&selected=org.utplsql%3Autplsql-maven-plugin%3Asrc%2Fmain%2Fjava%2Forg%2Futplsql%2Fmaven%2Fplugin%2FUtPLSQLMojo.java&view=list

jgebal commented 4 years ago

It seems that coverage is not getting gathered on pull requests or something...

sonarcloud[bot] commented 4 years ago

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

jgebal commented 4 years ago

I ran the MVN in debug mode. Jacoco sonar import cannot find any Jacoco reports for some reason.

[INFO] 00:17:16.784 Sensor HTML [web] (done) | time=6ms
[INFO] 00:17:16.784 Sensor JaCoCo XML Report Importer [jacoco]
[DEBUG] 00:17:16.788 No reports found
[INFO] 00:17:16.788 Sensor JaCoCo XML Report Importer [jacoco] (done) | time=4ms
[INFO] 00:17:16.788 Sensor ThymeLeaf template sensor [securityjavafrontend]
[INFO] 00:17:16.789 Sensor ThymeLeaf template sensor [securityjavafrontend] (don

Full raw build log here: https://api.travis-ci.org/v3/job/672308796/log.txt or here: https://travis-ci.org/github/utPLSQL/utPLSQL-maven-plugin/builds/672308795

jgebal commented 4 years ago

There is a lot of valuable code here. I don't want lack of coverage report to be a blocker for merging this. @pesse - We can merge this if you're OK. Jacoco reporting on the project can be solved post-release - what do you think?

pesse commented 4 years ago

Yes, sure. I will try to get it running in a test setup, but current times are not that side-hobby friendly 😉

viniciusam commented 4 years ago

Thanks, I'm gonna merge it then. I have a branch with some code refactoring, so I might get the coverage up on that.