utPLSQL / utPLSQL-maven-plugin

Maven plugin for running Unit Tests with utPLSQL v3
Apache License 2.0
13 stars 10 forks source link

excludeObject and includeObject doesn't work for multiple values #62

Closed Gepar closed 2 years ago

Gepar commented 2 years ago

According to documentation we can do this: <excludeObject>app.test1,app.test2</excludeObject> But according to maven plugin sources we can pass only one parameter because string is passing without split by any delimiter

                if (isNotBlank(excludeObject)) {
                    runner.excludeObject(excludeObject);
                }
simasch commented 2 years ago

Thank you for reporting the issue @Gepar

I'll create a bugfix release in the next few days

simasch commented 2 years ago

Also includeObject has the same issue

diamond54321 commented 2 years ago

@simasch, it seams there is a bug in your commit:

if (isNotBlank(includeObject)) {
                    if (includeObject.contains(",")) {
                        String[] includes = includeObject.split(",");
                        runner.excludeObjects(Arrays.asList(includes));
                    } else {
                        runner.excludeObject(includeObject);
                    }
                }

includeObject goes to runner.excludeObject now

simasch commented 2 years ago

Hi @diamond54321 Thanks a lot for the your bug report. I'll go ahead and fix this asap

simasch commented 2 years ago

Added a new issue for this: #64

simasch commented 2 years ago

@diamond54321 a new release 3.1.9 with the fix has been released

diamond54321 commented 2 years ago

@simasch thanks a lot for the rapid fix