search

utahiosmac / Marshal

Marshaling the typeless wild west of [String: Any]
MIT License
698 stars 63 forks source link

Add support for swift-tools-version:4.0 #140

Closed iosdevzone closed 5 years ago

iosdevzone commented 5 years ago

I ran into some issues using SPM version 5.0. It complained about unresolvable dependencies, but really the issue seemed to be that the Package.swift needed to be updated. I updated it to swift-tools-version:4.0 (so it should work with both SPM 4.x.x and 5.x.x -- I only tested with 5.0.0).

To keep things consistent I bumped the version in the podspec and tagged the whole shebang as 1.2.8 and everything seems to work fine now.

I hope this is useful to you!

bwhiteley commented 5 years ago

Why did you create Package@swift-4.swift instead of changing Package.swift?

iosdevzone commented 5 years ago

Changing Package.swift would mean that folks using earlier versions of the swift package manager would no longer be able to build the project. If you have a Package.swift and a Package@swift-4.swift you can be compatible with the newer tools and the older tools. Since it's not my repo I did not want to presume to break builds for earlier versions ;-)