search

utahiosmac / Marshal

Marshaling the typeless wild west of [String: Any]
MIT License
697 stars 62 forks source link

Added unit tests. #15

Closed bwhiteley closed 8 years ago

bwhiteley commented 8 years ago

Added unit tests from bwhiteley/JaSON.

brianmullen commented 8 years ago

In response to the NSDate tests...I think it's a great idea to give examples and/or sample code for users to drop in. I just don't think it belongs with the test cases.

jarsen commented 8 years ago

Yeah, I don't know if we need to test the extensibility of ValueType? Seems like if the compiler compiles, it's good. Right?

@psychoticidiot I don't know if you were just making a comment or didn't see, but the NSDate extension example is in the README.

brianmullen commented 8 years ago

@jarsen This commit includes the NSDate extension in addition to standard test cases for the library. I was under the assumption that we weren't going to include that extension in the library. @bwhiteley pointed out that it would be good to include it as an example for users or they could just copy the code and drop it in their project.

What I was saying is that if we are going to include sample/example code for users that isn't included in the library that it shouldn't clutter up the unit tests. Maybe we should have a separate examples folder that includes it.