search

utahnlp / layer_augmentation

Implementation of the NLI model in our ACL 2019 paper: Augmenting Neural Networks with First-order Logic.
Apache License 2.0
42 stars 6 forks source link

Code error for n3.py? #3

Open pangzhan27 opened 4 years ago

pangzhan27 commented 4 years ago

Based on your paper, Z1 and Z2 should be connected with disjuntion for this NLI task. However, in n3.py file, it seems that your implement is about conjunction. i don't know if my understanding is correct.

t-li commented 4 years ago

Hey, Thank you for the feedback. The repo is not actively monitored. Sorry about the late response.

We are looking at this issue and will update on this soon.

t-li commented 4 years ago

Hey, triple checking the code and the paper, I think it's a typo in the paper. The code is what we did in the experiments. I just submitted a correction request to the ACL anthropology. Here you go (in case you also want to keep track of that): https://github.com/acl-org/acl-anthology/issues/951

t-li commented 4 years ago

And we have also updated the arxiv version. FYI.