utat-ss / HERON-pcbs

PCB designs
Other
6 stars 2 forks source link

Systems PCB iteration #31

Closed brunofalmeida closed 5 years ago

brunofalmeida commented 6 years ago

Notes for the new iteration of the systems PCB.

brunofalmeida commented 6 years ago

My initial inspection and suggestions:

LornaLan commented 6 years ago

Hey Bruno, thank you for your suggestion!

**I just noticed that the default labels are on the Top Overlay layer, while I have some labels on the Top layer. Should I move them all to the Top Overlay layer?

brunofalmeida commented 6 years ago

Thanks for the updates! I'll have to take a look at the previous iteration board in the lab to check some of these points. A lot of my suggestions were just things to consider.

brunofalmeida commented 6 years ago

Updates (will clarify in person):

LornaLan commented 6 years ago

Please check the new PCB layout I updated. Just started routing and will be happy about any comments about the new version.

LornaLan commented 6 years ago

Routing of the new board is finished (yay)! Two things: 1) Increase wire width for 5v line? Solar+ line? Batt+ line? (didn't get a response from Mitchell, will ask him again) 2) The 25pin D-sub header layout changed - two GND pins are moved farther from each other.

brunofalmeida commented 6 years ago

Nicely done, looking a lot better! Mostly smaller changes at this point; some of my suggestions are debatable, and some should be checked with Dylan/Ali and others.

For your points:

  1. Ask Mitchell, but generally traces for power lines need to be thicker to handle higher currents. Might need to define a design rule/constraint for the width of power traces.
  2. That footprint is from a standard library right? I'm not sure why that would happen. (confirm with Dylan)
LornaLan commented 6 years ago

Updated version now on Github.

dsub
brunofalmeida commented 6 years ago
alihaydaroglu commented 6 years ago

I think we should stick with the existing DSUB-25 for cost cutting purposes - we can keep the current wire and add some strain relief, and worst case we can cut and re-splice it if connections become iffy

alihaydaroglu commented 6 years ago

i already spoke to Lorna with suggestions about the width of power traces - i think it would be smart to route them from the top side of the connector and keep thicker traces all the way to the pins. it might get a little tight

brunofalmeida commented 6 years ago

@alihaydaroglu is a mini DSUB-25 connector more expensive than the normal one?

alihaydaroglu commented 6 years ago

yes, significantly. the cables especially

vogeldylan commented 6 years ago
brunofalmeida commented 6 years ago
vogeldylan commented 6 years ago
LornaLan commented 6 years ago

Summing up the changes need to make next:

Anything else? Thank you for all the suggestions and advices!

brunofalmeida commented 6 years ago

We'll need to check that the systems PCB header pin layouts are consistent with the systems wiring diagram I'm working on.

brunofalmeida commented 6 years ago
LornaLan commented 6 years ago
LornaLan commented 6 years ago
brunofalmeida commented 6 years ago

@LornaLan see the changes in the systems wiring diagram v0.5, notably:

LornaLan commented 5 years ago

Updates: Changed the D-sub layout according to systems wiring diagram. Some issues need to check:

brunofalmeida commented 5 years ago

We might want to add I2C_SCL and I2C_SDA to the systems debug header, but is there anything that would be worth taking out?

vogeldylan commented 5 years ago

Systems PCB Review Part 1

  1. CUSTOM.SchLib, system_debug_pcb.OutJob, Conn_Molex_39-30-1020_eec.SchLib and Conn_Molex_39-30-1020_eec_0.PcbLib could not be found upon opening the project. The molex connectors should already be in CONNS.PcbLib as design item ID WM1351-ND. Please use the heron-general libraries, or integrate any additional components you require into these libraries. It will avoid any problems like this.
  2. Your panel connectors look correct.
  3. Your battery connector looks correct, just remember to label +ve and -ve terminals on PCB silkscreen
  4. Don't see any updates to PCB on your commit. Please push or add the changes to the PCB.
vogeldylan commented 5 years ago

@LornaLan

LornaLan commented 5 years ago
  1. Fixed the issue by organizing .schLib and .pcbLib to Heron General (will merge them into one single library soon after) with the latest commit 2, 3 Thanks! Should be labelled already.
  2. Fixed.
vogeldylan commented 5 years ago

Systems PCB Review Part 2

  1. More board needed for the connector; I went in and pushed it back. image
  2. You seem to be missing all of your GND and 3V3 vias on the board, so I added them. image
  3. Changed routing of PANEL+X+ and PANEL+X- to large polygons on VCC and GND layers, since the existing trace width was too thin. Also changed BATT nets to polygons.
  4. Imported UTAT SS Rules file, re-enabled all of your batch DRC checks that were disabled and re-ran DRC.
  5. Fixed outstanding DRC errors.
  6. Otherwise, board looks good. Should be ready to send out.
brunofalmeida commented 5 years ago

My Review - Part 1

  1. Can the programming headers have a notch to indicate the orientation of the programming header? image

  2. What does "RTC" mean in the top left debugging header? I think this isn't clear and should be more specific. image

  3. Can you flip the directions of the numbers and P1 in the debugging header? image

LornaLan commented 5 years ago

For @vogeldylan:

  1. Why are Vias still needed there when we have board size ground/vcc pour? Thank you for all the fixes!

For @brunofalmeida:

  1. Which one is the right orientation? Is the notch on 2-6 or 1-5 side?
  2. Changed to RTC-BATT, is it better?
  3. Fixed
vogeldylan commented 5 years ago

@lornalan vias are needed because the GND and VCC pours are on internal layers. To connect the top-side to GND and VCC requires dropping vias down.

brunofalmeida commented 5 years ago

@LornaLan

  1. The notch should be on the 1-5 side, see #48.
  2. I think RTC_BATT would be better than RTC-BATT. I first thought RTC-BATT meant negative BATT according to the naming convention, so I think using an underscore would be clearer. It's already much better than RTC though.

My Review - Part 2

(I know these are mostly small aesthetic changes)

  1. Why do we need two separate LEDs for PANEL+ and PANEL- ? Is PANEL- just connected to GND or am I just confused on this? image

  2. Is part of the "BATT PWR" label going to be covered up by the connector below? Might want to rename "BATT PWR" to "BATT"? image

  3. I suggest renaming SOLAR+ to +SOLAR to match +PACK and the systems wiring diagram. That way it's more consistent with how you've structured the board labels (i.e. +PACK and +SOLAR for EPS monitoring, PANEL+ and BATT+ for "simulated" solar and battery signals) image image

  4. Might want to move the RUN and PGM labels on the far right (for PAY) a bit closer to the switch to match the others. image

vogeldylan commented 5 years ago

@brunofalmeida you are correct, -PACK eventually gets connected to GND on EPS. Either way, current will only conduct in the other direction so the LED won't turn on.

brunofalmeida commented 5 years ago

So the PANEL- LED should be removed?

vogeldylan commented 5 years ago

Looks good d8ca9a4378e3418f5c5fd697efb40c93b7860bde