Closed brunofalmeida closed 5 years ago
My initial inspection and suggestions:
systems
folder in the root of the repoHey Bruno, thank you for your suggestion!
**I just noticed that the default labels are on the Top Overlay layer, while I have some labels on the Top layer. Should I move them all to the Top Overlay layer?
Thanks for the updates! I'll have to take a look at the previous iteration board in the lab to check some of these points. A lot of my suggestions were just things to consider.
Updates (will clarify in person):
Please check the new PCB layout I updated. Just started routing and will be happy about any comments about the new version.
Routing of the new board is finished (yay)! Two things: 1) Increase wire width for 5v line? Solar+ line? Batt+ line? (didn't get a response from Mitchell, will ask him again) 2) The 25pin D-sub header layout changed - two GND pins are moved farther from each other.
Nicely done, looking a lot better! Mostly smaller changes at this point; some of my suggestions are debatable, and some should be checked with Dylan/Ali and others.
For your points:
print()
calls go to TX)Updated version now on Github.
I think we should stick with the existing DSUB-25 for cost cutting purposes - we can keep the current wire and add some strain relief, and worst case we can cut and re-splice it if connections become iffy
i already spoke to Lorna with suggestions about the width of power traces - i think it would be smart to route them from the top side of the connector and keep thicker traces all the way to the pins. it might get a little tight
@alihaydaroglu is a mini DSUB-25 connector more expensive than the normal one?
yes, significantly. the cables especially
Summing up the changes need to make next:
Anything else? Thank you for all the suggestions and advices!
We'll need to check that the systems PCB header pin layouts are consistent with the systems wiring diagram I'm working on.
@LornaLan see the changes in the systems wiring diagram v0.5, notably:
Updates: Changed the D-sub layout according to systems wiring diagram. Some issues need to check:
We might want to add I2C_SCL and I2C_SDA to the systems debug header, but is there anything that would be worth taking out?
CUSTOM.SchLib
, system_debug_pcb.OutJob
, Conn_Molex_39-30-1020_eec.SchLib
and Conn_Molex_39-30-1020_eec_0.PcbLib
could not be found upon opening the project. The molex connectors should already be in CONNS.PcbLib as design item ID WM1351-ND. Please use the heron-general libraries, or integrate any additional components you require into these libraries. It will avoid any problems like this.@LornaLan
Can the programming headers have a notch to indicate the orientation of the programming header?
What does "RTC" mean in the top left debugging header? I think this isn't clear and should be more specific.
Can you flip the directions of the numbers and P1 in the debugging header?
For @vogeldylan:
For @brunofalmeida:
@lornalan vias are needed because the GND and VCC pours are on internal layers. To connect the top-side to GND and VCC requires dropping vias down.
@LornaLan
(I know these are mostly small aesthetic changes)
Why do we need two separate LEDs for PANEL+ and PANEL- ? Is PANEL- just connected to GND or am I just confused on this?
Is part of the "BATT PWR" label going to be covered up by the connector below? Might want to rename "BATT PWR" to "BATT"?
I suggest renaming SOLAR+ to +SOLAR to match +PACK and the systems wiring diagram. That way it's more consistent with how you've structured the board labels (i.e. +PACK and +SOLAR for EPS monitoring, PANEL+ and BATT+ for "simulated" solar and battery signals)
Might want to move the RUN and PGM labels on the far right (for PAY) a bit closer to the switch to match the others.
@brunofalmeida you are correct, -PACK eventually gets connected to GND on EPS. Either way, current will only conduct in the other direction so the LED won't turn on.
So the PANEL- LED should be removed?
Looks good d8ca9a4378e3418f5c5fd697efb40c93b7860bde
Notes for the new iteration of the systems PCB.