Please, go through these steps before you submit a PR.
Make sure that your PR is not a duplicate.
If not, then make sure that:
a. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the fix/ or feature/ prefixes. Good examples are: fix/cudart_spec_build or feature/rdma_channel.
b. You have a descriptive commit message with a short title (first line).
c. You have only one or a small number of commits (if not, squash some into one commit).
d. Linter doesn't throw any error. If it does, fix them first (e.g. ./scripts/check_cpp_format.sh -fix .) and amend your commit (git commit --amend).
After these steps, you're ready to open a pull request.
a. Give a descriptive title to your PR.
b. Provide a description of your changes.
c. Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.
PLEASE REMOVE THE ABOVE CHECKLIST BEFORE SUBMITTING
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Document update (this change is mainly a documentation update)
Checklist:
[x] My code passes format and lint checks.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My changes generate no new warnings.
[ ] I have tested my code with a reasonable workload.
Signed-off-by: Zhiting Zhu zhitingz@cs.utexas.edu
Pull Request checklist
Please, go through these steps before you submit a PR.
Make sure that your PR is not a duplicate.
If not, then make sure that:
a. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the
fix/orfeature/prefixes. Good examples are:fix/cudart_spec_buildorfeature/rdma_channel.b. You have a descriptive commit message with a short title (first line).
c. You have only one or a small number of commits (if not, squash some into one commit).
d. Linter doesn't throw any error. If it does, fix them first (e.g.
./scripts/check_cpp_format.sh -fix .) and amend your commit (git commit --amend).After these steps, you're ready to open a pull request.
a. Give a descriptive title to your PR.
b. Provide a description of your changes.
c. Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.
PLEASE REMOVE THE ABOVE CHECKLIST BEFORE SUBMITTING
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: