search

utcs-scea / ava

Automatic virtualization of (general) accelerators.
https://ava.yuhc.me/
BSD 2-Clause "Simplified" License
40 stars 20 forks source link

[BUG] Generator CMakeLists.txt assumes build artifacts already exist #144

Open vancemiller opened 3 years ago

vancemiller commented 3 years ago

Describe the bug Try initializing the cmake build system on a new clone of the repository.

To Reproduce Try initializing the cmake build system on a new clone of the repository. 

cmake -DAVA_GEN_CUDART_SPEC=On -DAVA_MANAGER_LEGACY=On ../ava
# note out of source tree build

Expected behavior Cmake completes successfully.

Error log

CMake Error at cava/CMakeLists.txt:39 (add_subdirectory):
  add_subdirectory given source "cudart_nw" which is not an existing
  directory.
photoszzt commented 3 years ago

You need to run generate.py first. It needs a better error message to inform the user.

vancemiller commented 3 years ago

Can this be automated as part of running cmake?

On Wed, Jun 2, 2021, 10:05 AM Zhiting Zhu @.***> wrote:

You need to run generate.py first. It needs a better error message to inform the user.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/utcs-scea/ava/issues/144#issuecomment-853056796, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQTX2SPCPXUBP5OQLZLKE3TQY3A7ANCNFSM456WRA4A .

photoszzt commented 3 years ago

It could be. https://cmake.org/cmake/help/latest/command/execute_process.html But it will make the configure time longer.

vancemiller commented 3 years ago

That seems ok. Better to keep the build process as simple as possible.