🐛 Adds 'reindex' action on sort to sortable publications html container

utdal / profiles

A simple CRUD/search profile system for research profiles, providing user-editable information and basic pages to aesthetically promote and highlight researcher activities and achievements.

MIT License

6 stars 0 forks source link

🐛 Adds 'reindex' action on sort to sortable publications html container #143

Closed betsyecastro closed 3 months ago

betsyecastro commented 3 months ago

Fixes bug in issue #141.

Used git bisect to find commit and diagnose issue that causes the publications rows rearranging feature to break in publications edit page:

fbd8492e44b7d345f84669d56a9bbf17371d8196 is the first bad commit - Custom student questions (#122).

wunc commented 3 months ago

@betsyecastro Thank you for finding the cause and proposing a fix. Git bisect sounds useful! I double-checked, and I think the previous behavior for profile-data sorting was to not reindex the items. So, I've modified this PR so that the function just properly handles the case where the data-onsort attribute is missing. (I think the changes I implemented for the student questions wasn't meant to affect the profile data editing.)