Add project_configuration_tool option to template

utdemir / hs-nix-template

A Haskell project template that uses Nix and comes with cabal-install, ghcid, ormolu, haskell-language-server and more.

MIT License

103 stars 12 forks source link

Add project_configuration_tool option to template #21

Closed chiroptical closed 3 years ago

chiroptical commented 3 years ago

Closes #20

Add an option project_configuration_tool which writes package.yaml instead of your-project-name.cabal
Added an additional CI step which overrides the default project_configuration_tool to hpack to test all configuration options
I used stack new example-project to approximate a minimal package.yaml file with the changes you made in the cabal template

utdemir commented 3 years ago

Thanks for the PR! I just wanted to tell you that I am a bit busy this week, so I will review this over the weekend; but I will definitely get to this!

chiroptical commented 3 years ago

@utdemir I believe I addressed all the issues you pointed out. Thanks for the great input! Also, if you have any other features in mind feel free to bother me about them. I plan to use this template for the foreseeable future and would be happy to dev on it.

utdemir commented 3 years ago

Thank you for the changes :). And I apologize for the late reply, I was a bit busy at work.

Also, if you have any other features in mind feel free to bother me about them. I plan to use this template for the foreseeable future and would be happy to dev on it.

Well, one feature I'd really appreciate to have would be #19 , #18 , and similarly supporting benchmarks. I was also thinking about migrating to use tasty-discover alongside with tasty-hunit and tasty-hedgehog. If any of them is interesting to you, feel free to work on it!

I am also happy to make you a maintainer if you are planning to contribute, just let me know if you are keen.

Thanks again!

chiroptical commented 3 years ago

I am also happy to make you a maintainer if you are planning to contribute, just let me know if you are keen.

I don't mind at all! I'll likely pick up some of these issues soon. Thanks!