search

utelle / wxsqlite3

wxSQLite3 - SQLite3 database wrapper for wxWidgets (including SQLite3 encryption extension)
http://utelle.github.io/wxsqlite3
Other
589 stars 178 forks source link

new CMake option and some cleanup #69

Closed Deamhan closed 5 years ago

Deamhan commented 5 years ago

Some static have been added & one declaration. RTTI enabled by default now (CMake).

utelle commented 5 years ago

In your cleanup of the minimal sample you used the macro wxDECLARE_APP. That's the reason why CI currently fails. Intentionally wxSQLite3 is kept compatible with the older wxWidgets version 2.8.12, in which the macro name is DECLARE_APP.

I already applied adjustments to the minimal sample in commit 510cbda852e8598a1bc9fd8ad1c07cfe45f0d773. Unfortunately, the github web environment doesn't support cherry picking. Therefore, please provide a separate PR for the adjustments to CMakeLists.txt. Thanks.

Deamhan commented 5 years ago

Yes, I see... Done: https://github.com/utelle/wxsqlite3/pull/70