Support Code128 auto-detection

utensils / barcoded

A barcode generation web service.

utensils.io/barcoded

MIT License

49 stars 5 forks source link

Support Code128 auto-detection #54

Closed doomspork closed 10 years ago

doomspork commented 10 years ago

RFC @jamesbrink (and any interested parties) — This PR removes support for code-128a, code-128b, and code-128c in favor of code-128 which handles auto-detection and supports multiple subsets within a single barcode.

This requires at least Barby 0.6.0.

In order to support for multiple subset barcodes I needed to add support for escaping/unescaping URIs, something we should have done originally — oops!

coveralls commented 10 years ago

Coverage increased (+0.0%) when pulling 13f874281130c3c3a7bdcbc00b24704fb20112fd on doomspork:support-code128-autodetect into 84702142572cb8187d2e7ca90458da52627d11e6 on UtensilsUnion:master.

jamesbrink commented 10 years ago

Looks good to me, do we need any readme updates? We will need to update the demo page as well.

doomspork commented 10 years ago

Oh! Good catch, I'll update the README. The demo will need to be a separate PR because it requires a new Dockerfile to be shipped, right? I figured we could update it all together when we ship 0.2.0.

coveralls commented 10 years ago

Coverage remained the same when pulling 187db5c20c5a1e693b42958f9a55584c1c13721e on doomspork:support-code128-autodetect into f5aebb363ce9a4537c21c047362d1e85940c242f on UtensilsUnion:master.