search

utexas-bwi / bwi_lab

Scripts and other programs for administering the BWI system network
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Added ability to upload experimental bags #3

Closed pato closed 8 years ago

pato commented 8 years ago

Made the parameter parsing more rich by allowing the ability to also specify whether you want experimental bag files (of the form extra_*.bag) to be compressed and uploaded as well as outlined in issue #2

jack-oquin commented 8 years ago

Here again, all I think we really need is to add a parameter for the bag file prefix. Then, we can just run the command once for each desired prefix (bwi_, extras_).

pato commented 8 years ago

Rewrote it to take a parameter for the prefix (or default to bwi). Take a look @jack-oquin and tell me what you think

jack-oquin commented 8 years ago

Other than two trivial problems, it looks good to me.

Thanks for working on this, Pato. I'd like to merge it before doing some further improvements to the upload script.

jack-oquin commented 8 years ago

See #4 for some further changes I'd like to make after this PR is merged.

pato commented 8 years ago

I've made all the changes you pointed out (also realized i was still using a hardcoded bwi_*.bag glob match, so I fixed that. Should be good to go now! Thanks for the review

jack-oquin commented 8 years ago

Looks good, thanks.

Glad you caught that other glob. That bug would have been embarrassing, :smile: