search

utexas-bwi / bwi_lab

Scripts and other programs for administering the BWI system network
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

require explicit prefix for upload and bags scripts #7

Closed jack-oquin closed 8 years ago

jack-oquin commented 8 years ago

I think we should consider always requiring the -p parameter. Otherwise people will often forget and end up using bwi by default. When running the scripts by hand, that's frequently not what is wanted.

If we do this, we could also make a similar change to the bwi_logging record node. I'm not sure that's really necessary, because the launch file always passes that parameter explicitly.

@pato: comments? suggestions?

pato commented 8 years ago

I definitely agree. I am all for removing any possible source of confusion. We should definitely enforce the parameter in the upload, and I believe we will also need to change the bwi_logging record node. AFAIK I only made the bwi parameter explicit in the launch file, but it still defaults to bwi in the node. I will assign this to myself and make those changes

jack-oquin commented 8 years ago

When typing the commands, it will be more convenient to replace the -p option with a mandatory positional argument:

 $ bwi bags [options] PREFIX

For consistency, that should work the same for both the bags and upload scripts.

jack-oquin commented 8 years ago

@pato: You did leave the prefix parameter default as bwi in the logging node.

I'm content to leave that alone. Otherwise the logging node would have to refuse to run, not good behavior for a ROS node.

jack-oquin commented 8 years ago

@pato: I reassigned this issue to myself, because I'm ready to make this change, now.

Hope that does not interfere with anything you were already doing.

jack-oquin commented 8 years ago

It's working for me.