utexas-bwi / eband_local_planner

ROS Local planner based on the eband approach. Based on the original implementation by Christian Connette and Bhaskara Marathi. This local planner has been adapted primarily for differential drive robots, but still supports the original holonomic drive controls.
http://wiki.ros.org/eband_local_planner
105 stars 83 forks source link

eband_local_planner lack of documentation #20

Closed rlefevre1 closed 8 years ago

rlefevre1 commented 8 years ago

Hello ! I didn't find anywhere a documentation about the list of available parameters for the eband_local_planner. It would be nice if anyone can provide it. Thanks.

jack-oquin commented 8 years ago

+1

piyushk commented 8 years ago

@raflef11: I'll see what I can do, but it might be a couple of weeks before I can get this documentation up. The most important parameters are in eband_trajectory_controller_ros.cpp.

jack-oquin commented 8 years ago

@piyushk: maybe one of the summer students could write something up from reading the code.

This is something we'd like to have documented.

piyushk commented 8 years ago

@jack-oquin: I've tried getting students to read through that code over the years, but it's a tough piece. I've never seen progress.

rlefevre1 commented 8 years ago

@piyushk Thank you for your help. I found parameters I needed in eband_trajectory_controller.cpp.

I think that the list of parameters could be displayed in the ros web page for the eband_local_planner (like the others planners). It is more convenient.

Thanks again

jack-oquin commented 8 years ago

@raflef11: please let us know if differential_drive=false works for you.

jack-oquin commented 8 years ago

I made a start at listing some of the ROS parameters. Many of the others would require guess-work on my part.

@piyushk: Please verify or correct my guess that the parameter namespace would be: ~/eband_local_planner.

rlefevre1 commented 8 years ago

@jack-oquin Yes, for me differential_drive=false works properly.

But I have a problem: the parameters does not appear in the parameter server (when I type rosparam list there is no result for the eband_local_planner).

jack-oquin commented 8 years ago

But I have a problem: the parameters does not appear in the parameter server (when I type rosparam list there is no result for the eband_local_planner).

How did you set them?

rlefevre1 commented 8 years ago

How did you set them?

I created a YAML file which contains the following lines:

EBandPlannerROS:

  differential_drive: false
  rotation_correction_threshold: 1.0

Then, I load it through a launch file as follows:

<launch>

  <arg name="base_global_planner" default="navfn/NavfnROS"/>
  <arg name="base_local_planner" default="eband_local_planner/EBandPlannerROS"/>

  <node pkg="move_base" type="move_base" respawn="false" name="move_base" output="screen">
    <param name="base_global_planner" value="$(arg base_global_planner)"/>
    <param name="base_local_planner" value="$(arg base_local_planner)"/>
    <rosparam file="$(find my_package)/config/costmap_common_params.yaml" command="load" ns="global_costmap" />
    <rosparam file="$(find my_package)/config/costmap_common_params.yaml" command="load" ns="local_costmap" />
    <rosparam file="$(find my_package)/config/local_costmap_params.yaml" command="load" />
    <rosparam file="$(find my_package)/config/global_costmap_params.yaml" command="load" />
    <rosparam file="$(find my_package)/config/eb_planner.yaml" command="load" /> <!-- HERE I LOAD THE PARAMETERS INSIDE THE YAML FILE -->
  </node>

</launch>
jack-oquin commented 8 years ago

What does this command print?

rosparam list | grep differential
rlefevre1 commented 8 years ago

I already tried this command but it return nothing

rlefevre1 commented 8 years ago

Oh, it's good, I don't know what I changed but it works now, thank you

jack-oquin commented 8 years ago

@raflef11: What was the full name of your parameter?

I am wondering whether the documentation I wrote is correct.

rlefevre1 commented 8 years ago

The full names of the parameters I use are:

/move_base/EBandPlannerROS/differential_drive
/move_base/EBandPlannerROS/rotation_correction_threshold

These are the values in the parameter server.

jack-oquin commented 8 years ago

So, EBandPlannerROS is the name under which you configured the base_local_planner?

That means my documentation is wrong. I thought it would be eband_local_planner.

rlefevre1 commented 8 years ago

Yes, I used EBandPlannerROS as you can see above (where I wrote the YAML file content). The documentation is effectively wrong ;)

jack-oquin commented 8 years ago

I think it's better now. Please check, and comment here if it's still wrong.

rlefevre1 commented 8 years ago

It seems to be good

jack-oquin commented 8 years ago

Thanks for your help.

rlefevre1 commented 8 years ago

You likewise.