search

utexas-bwi / rocon_scheduler_requests

Interfaces for managing rocon scheduler requests
http://wiki.ros.org/rocon_scheduler_requests
0 stars 3 forks source link

Remove scheduled request priorities. #11

Closed stonier closed 10 years ago

stonier commented 10 years ago

Remove usage of depracated priority flag in ScheduledRequests.msg

This needs to be updated for the change in https://github.com/robotics-in-concert/rocon_msgs/issues/46

jack-oquin commented 10 years ago

That is not the only place we need to change.

Do you need this merged soon, or can you work in your own fork for now?

I am currently working on some improvements to the message handling. There are some bugs in it that I am still trying to find. After that, I plan to merge your rocon_msgs update and make this change.

stonier commented 10 years ago

Yeah, quickly discovered that when I instantiated the scheduler. The second commit traces it through to the request set where it is no longer currently used as well.

Doesn't need to be merged - I can work off my fork for a while and sync with you the other way.

jack-oquin commented 10 years ago

I am planning to leave the Requester.priority parameter in, but take it out of the RequestSet and the message. Just store it in the Requester class for use as a default for new_request().

Does that seem reasonable?

stonier commented 10 years ago

Yeah. Thats what I did here in those commits. On 6 Dec 2013 12:06, "jack-oquin" notifications@github.com wrote:

I am planning to leave the Requester.priority parameter in, but take it out of the RequestSet and the message. Just store it in the Requesterclass for use as a default for new_request().

Does that seem reasonable?

— Reply to this email directly or view it on GitHubhttps://github.com/utexas-bwi/rocon_scheduler_requests/pull/11#issuecomment-29960297 .

jack-oquin commented 10 years ago

Note that 2d2164ed88520266561d8b328582dbd042ed3e25 requires an explicit call to Requester.send_requests() after calling new_request() one or more times. Otherwise the request will not be sent until the next heartbeat timer event.

stonier commented 10 years ago

Good, thanks for the heads up.