Open ismailshak opened 6 months ago
The current method for getting the icon for a file doesn't account for nested file extensions
An example of this is some-file.test.ts. The current implementation will only load ts icons but will miss the icon for test.ts.
some-file.test.ts
ts
test.ts
Before fix:
After fix:
The screenshots were testing the default nvim-web-devicons set for test.ts vs .ts
nvim-web-devicons
.ts
We could make this more future-proof by recursively testing the nested extensions against the list of icons provided by nvim-web-devicons, but I couldn't think of a use case for this so opted out of supporting that just in case it was overkill
EDIT: oh hey, 100th PR 🎈 lol
The current method for getting the icon for a file doesn't account for nested file extensions
An example of this is
some-file.test.ts. The current implementation will only loadtsicons but will miss the icon fortest.ts.Before fix:
After fix:
The screenshots were testing the default
nvim-web-deviconsset fortest.tsvs.tsWe could make this more future-proof by recursively testing the nested extensions against the list of icons provided by
nvim-web-devicons, but I couldn't think of a use case for this so opted out of supporting that just in case it was overkillEDIT: oh hey, 100th PR 🎈 lol