search

utilyre / barbecue.nvim

Visual Studio Code inspired breadcrumbs plugin for the Neovim editor
MIT License
778 stars 31 forks source link

fix: load after `nvim-web-devicons` (fixes #31) #32

Closed sravioli closed 1 year ago

sravioli commented 1 year ago

fixes the conflict with nvim-web-devicons by loading barbecue.nvim after it.

utilyre commented 1 year ago

Doesn't the requires = "kyazdani42/nvim-web-devicons" part do the same thing?

sravioli commented 1 year ago

kinda, requires = "kyazdani42/nvim-web-devicons" tells packer that barbecue.nvim needs that plugin to work, but not the specific order in which to load the plugins. We do that with the after command, this way we avoid any conflict with nvim-web-devicons.

I saw it discussed in the NvChad repo (here)

Adding that after, fixed all the issues. Maybe it conflicts specifically with NvChad, i don't really know.

utilyre commented 1 year ago

Please rebase towards dev and force push.

sravioli commented 1 year ago

Please rebase towards dev and force push.

i changed the PR target, i wrote the PR from GitHub since it was a oneliner.

utilyre commented 1 year ago

Please rebase towards dev and force push.

i changed the PR target, i wrote the PR from GitHub since it was a oneliner.

I don't know how to do this on the github web, but please clone your fork (with --branch patch-1) and run the following

git rebase remotes/origin/dev
git push -f
sravioli commented 1 year ago

ok soo, should i still clone and stuff?

utilyre commented 1 year ago

ok soo, should i still clone and stuff?

Yep, because your pr contains duplicated commits from dev which hasn't been merged yet.

sravioli commented 1 year ago

okok, i just did

utilyre commented 1 year ago

Thanks!

sravioli commented 1 year ago

no problem :)