search

utilyre / barbecue.nvim

Visual Studio Code inspired breadcrumbs plugin for the Neovim editor
MIT License
807 stars 35 forks source link

feat: omit highlight groups in string length #49

Closed f1rstlady closed 1 year ago

f1rstlady commented 1 year ago

When calculating the length of the custom section, the substrings changing the highlight group are counted although not being displayed. This leads to erroneous truncation.

Omitting the highlight groups substrings in the string length calculation fixes this issue.

utilyre commented 1 year ago

This PR seems to be complete. Was it intended to be a draft?

f1rstlady commented 1 year ago

Yes, it is complete. I submitted it as a draft due to this line in the contribution guidelines.

utilyre commented 1 year ago

I didn't mean to keep it as a draft, you should make a draft PR when you work on it so that other people won't start working on the same thing. Once it is complete mark it as "Ready for review".

But that's a fair point, I'll make it more clear in the contributing file.

f1rstlady commented 1 year ago

Ok, that makes sense!