Closed jptech closed 6 years ago
resolves #26
Merging #46 into dev will increase coverage by
0.68%
. The diff coverage is94.88%
.
@@ Coverage Diff @@
## dev #46 +/- ##
==========================================
+ Coverage 93.73% 94.42% +0.68%
==========================================
Files 53 56 +3
Lines 2538 2886 +348
==========================================
+ Hits 2379 2725 +346
- Misses 159 161 +2
Impacted Files | Coverage Δ | |
---|---|---|
arduino_gen/include/arduino_gen/appendage.hpp | 100% <ø> (ø) |
:arrow_up: |
arduino_gen/include/arduino_gen/arduino_gen.hpp | 100% <ø> (ø) |
:arrow_up: |
arduino_gen/include/arduino_gen/includes.hpp | 100% <ø> (ø) |
:arrow_up: |
arduino_gen/src/constructors.cpp | 100% <100%> (+7.31%) |
:arrow_up: |
arduino_gen/test/test_appendage.cpp | 100% <100%> (ø) |
:arrow_up: |
arduino_gen/test/test_constructor.cpp | 100% <100%> (ø) |
|
arduino_gen/src/xml_utils.cpp | 100% <100%> (+2.5%) |
:arrow_up: |
arduino_gen/include/arduino_gen/utils.hpp | 100% <100%> (ø) |
:arrow_up: |
arduino_gen/include/arduino_gen/constructor.hpp | 100% <100%> (ø) |
|
arduino_gen/test/test_constructors.cpp | 100% <100%> (ø) |
:arrow_up: |
... and 8 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0c727b6...5fe813a. Read the comment docs.
This looks good enough to go ahead and merge. It seems HW testing has not been completed, but otherwise, this is a great start. Thanks @xxAtrain223 for all your work.
I am opening the PR so that people can go ahead and look over Anthony's recent work. If anything needs to be changed, please point it out ASAP with a review.
A few points:
dev
branch needs to merge into this, and we are likely to have some conflicts.