search

utk09-NCL / color-palette-generator

Color Conjure - Color Palette Generator
https://color-conjure.netlify.app
MIT License
26 stars 15 forks source link

Feat: 16 - Add a footer to the website #30

Open Aditi2k5 opened 1 month ago

Aditi2k5 commented 1 month ago

Is your feature request related to a problem? Please describe

Describe the Solution You'd Like

Describe Alternatives You've Considered N/A

Additional Context N/A

utk09-NCL commented 1 month ago

So we already have another open PR for header/navbar - https://github.com/utk09-NCL/color-palette-generator/issues/27

But I guess we could make this a footer PR. Would you like to work on it?

Also, may I kindly request you to please follow the Feature Template. Example 1: https://github.com/utk09-NCL/color-palette-generator/issues/25 Example 2: https://github.com/utk09-NCL/color-palette-generator/issues/29

Aditi2k5 commented 1 month ago

Yes I can work on that issue

On Sun, Oct 13, 2024, 3:04 PM Utkarsh Tiwari @.***> wrote:

So we already have another open PR for header/navbar - #27 https://github.com/utk09-NCL/color-palette-generator/issues/27

But I guess we could make this a footer PR. Would you like to work on it?

Also, may I kindly request you to please follow the Feature Template. Example 1: #25 https://github.com/utk09-NCL/color-palette-generator/issues/25 Example 2: #29 https://github.com/utk09-NCL/color-palette-generator/issues/29

— Reply to this email directly, view it on GitHub https://github.com/utk09-NCL/color-palette-generator/issues/30#issuecomment-2408903433, or unsubscribe https://github.com/notifications/unsubscribe-auth/BC5W2462QWRURSWG5SVIWB3Z3I5C7AVCNFSM6AAAAABP25F5S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYHEYDGNBTGM . You are receiving this because you authored the thread.Message ID: @.***>

utk09-NCL commented 1 month ago

Thank you @Aditi2k5

Ideally what is required in the footer for now:

Aditi2k5 commented 1 month ago

Hey what should the copyright text include

From: Utkarsh Tiwari @.> Sent: Sunday, October 13, 2024 10:33 AM To: utk09-NCL/color-palette-generator @.> Cc: Aditi Prabakaran @.>; Mention @.> Subject: Re: [utk09-NCL/color-palette-generator] Feat: 16 - Add a footer to the website (Issue #30)

Thank you @Aditi2k5https://github.com/Aditi2k5

Ideally what is required in the footer for now:

— Reply to this email directly, view it on GitHubhttps://github.com/utk09-NCL/color-palette-generator/issues/30#issuecomment-2408922329, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC5W245WA5YRFYQPMG6CLSTZ3JD7VAVCNFSM6AAAAABP25F5S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYHEZDEMZSHE. You are receiving this because you were mentioned.Message ID: @.***>

utk09-NCL commented 1 month ago

Copyright ©️ 2024. All rights reserved.

Aditi2k5 commented 1 month ago

I have created a pr number #39 could you check and tell if it works?

From: Utkarsh Tiwari @.> Sent: Sunday, October 13, 2024 4:51 PM To: utk09-NCL/color-palette-generator @.> Cc: Aditi Prabakaran @.>; Mention @.> Subject: Re: [utk09-NCL/color-palette-generator] Feat: 16 - Add a footer to the website (Issue #30)

Copyright ©️ 2024. All rights reserved.

— Reply to this email directly, view it on GitHubhttps://github.com/utk09-NCL/color-palette-generator/issues/30#issuecomment-2409048076, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC5W24ZRNU4BTTU5Q5J2ZU3Z3KQITAVCNFSM6AAAAABP25F5S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBZGA2DQMBXGY. You are receiving this because you were mentioned.Message ID: @.***>

utk09-NCL commented 1 month ago
Screenshot 2024-10-13 at 18 16 51

Please check this design for Footer @Aditi2k5 Have left some comments on your PR as well

Aditi2k5 commented 1 month ago

Hey i have replied in mail but yes i understood and shall resolve them soon

Aditi2k5 commented 1 month ago

Hi I have made changes could you verify if it is fine now?

From: Utkarsh Tiwari @.> Sent: Sunday, October 13, 2024 5:17 PM To: utk09-NCL/color-palette-generator @.> Cc: Aditi Prabakaran @.>; Mention @.> Subject: Re: [utk09-NCL/color-palette-generator] Feat: 16 - Add a footer to the website (Issue #30)

Screenshot.2024-10-13.at.18.16.51.png (view on web)https://github.com/user-attachments/assets/e9044de2-78e2-4dab-9a61-def3880bf095

Please check this design for Footer @Aditi2k5https://github.com/Aditi2k5 Have left some comments on your PR as well

— Reply to this email directly, view it on GitHubhttps://github.com/utk09-NCL/color-palette-generator/issues/30#issuecomment-2409056565, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC5W245B6YV3ZSUSKSRY7ALZ3KTL5AVCNFSM6AAAAABP25F5S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBZGA2TMNJWGU. You are receiving this because you were mentioned.Message ID: @.***>

samorobo commented 1 month ago

@utk09-NCL Good day sir please could you assign me to this issue. I would like to take on the challenge create the footer

Aditi2k5 commented 1 month ago

Hi you can assign the issue to them as I'm not able to commit thr changes

On Wed, Oct 16, 2024, 9:09 PM samorobo @.***> wrote:

@utk09-NCL https://github.com/utk09-NCL Good day sir please could you assign me to this issue. I would like to take on the challenge create the footer

— Reply to this email directly, view it on GitHub https://github.com/utk09-NCL/color-palette-generator/issues/30#issuecomment-2417206436, or unsubscribe https://github.com/notifications/unsubscribe-auth/BC5W247UPSICKJTY7GJWWTDZ32CBTAVCNFSM6AAAAABP25F5S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXGIYDMNBTGY . You are receiving this because you were mentioned.Message ID: @.***>

utk09-NCL commented 1 month ago

Assigning it to you @samorobo

utk09-NCL commented 1 month ago

Any updates on this @samorobo ?

samorobo commented 1 month ago

@utk09-NCL I should be done with this by tommorow