utkarsh-1905 / time-table

Thapar University Time Table Generator App
https://timetable.mlsctiet.com
GNU General Public License v3.0
65 stars 21 forks source link

Fix: Displays contributors dynamicaly #37

Closed michaelmuthomi closed 1 year ago

michaelmuthomi commented 1 year ago

The fix uses GitHub's API to fetch the list of contributors

Before you can use it You need to get an access token form GitHub at https://github.com/settings/tokens?type=beta

You can then insert the token at home.html line 54 fixes #31

utkarsh-1905 commented 1 year ago

okay, but should we not include the access token in some environment variable rather than pushing it publicly, this can be a major security threat

michaelmuthomi commented 1 year ago

okay, but should we not include the access token in some environment variable rather than pushing it publicly, this can be a major security threat

@utkarsh-1905 Sure that True. I have done some modifications and now it doesn't need the access token.

utkarsh-1905 commented 1 year ago

looks great