search

utkarsh-1905 / time-table

Thapar University Time Table Generator App
https://timetable.mlsctiet.com
GNU General Public License v3.0
65 stars 21 forks source link

No B groups being shown #48

Closed madhavkapila closed 10 months ago

madhavkapila commented 10 months ago

Actually sir no B groups for 1st year were being shown.

Also sir I cloned the repo to try updating 23-24 Even Sem. According to what I understood(maybe I am wrong) I found all content from Excel file is extracted by golang file genData.go and coverted to json file. But after replacing old excel file by new(Even sem) file the json file was not being updated. Even if I would delete old json there was no new json file being created after running the code.

Please may you guide me here also.

utkarsh-1905 commented 10 months ago

to generate the the json source file, uncomment lines 22 and 23 in main.go file and run the server go run main.go

utkarsh-1905 commented 10 months ago

it's a very minor bug, there is a line error in Excel, I have fixed it and pushing it, since you raised the issue, you should get the credits, just pull the latest code, and make the JSON file using the above steps, validate the issue, and raise a PR

utkarsh-1905 commented 10 months ago

here you go @SmartKapila

madhavkapila commented 10 months ago

Thank you sir very much🙏🏻 for providing me this opportunity and honour. I have created a merge request. Please do the needful.

utkarsh-1905 commented 10 months ago

@SmartKapila I hope you have a better understanding of the project now

madhavkapila commented 10 months ago

@SmartKapila I hope you have a better understanding of the project now

Yes @utkarsh-1905 sir solely due to your guidance :)