search

utkarshkukreti / edn.rs

An EDN (Extensible Data Notation) parser in Rust.
48 stars 12 forks source link

Namespaced symbols and tagged values #1

Closed tie-rack closed 7 years ago

tie-rack commented 7 years ago

Namespaced symbols and tagged values are common in the edn that I interact with. This PR adds support for both.

utkarshkukreti commented 7 years ago

Hi @tie-rack, the code looks great! I'll try to review and merge tonight.

I'm also curious: are you using this library somewhere? I didn't think anyone was using this library.

tie-rack commented 7 years ago

Hi @utkarshkukreti. At this point, I'm just experimenting with adding a Rust component to a mostly Clojure system I work on. If this moves from an experiment to a real project, I'll let you know!

utkarshkukreti commented 7 years ago

Sorry for the delay, it was a busy week. Everything looks good! I've merged the commits. Let me know if/when you need a release on crates.io.

utkarshkukreti commented 7 years ago

What do you think about changing the variant's name from TaggedValue to just Tagged?

tie-rack commented 7 years ago

That name change makes sense. I'd be happy with that and a release whenever you have time. Thank you!