search

utkarshkukreti / markup.rs

A blazing fast, type-safe template engine for Rust.
Apache License 2.0
363 stars 15 forks source link

Make `itoa` an optional dependency under a new `faster` feature. #10

Closed utkarshkukreti closed 2 years ago

utkarshkukreti commented 4 years ago

This removes the only non-proc-macro dependency from the crate. If one cares about integer writing optimizations, they can enable this feature.

Urgau commented 2 years ago

Hi, I'm interested in this change. Is there something blocking this pull-request from being merged ?

This pull-request could also dump the itoa dependency to version 1.0.

ZaneHannanAU commented 2 years ago

I think itoa should be blocked under feature itoa, not only faster.

utkarshkukreti commented 2 years ago

@Urgau @ZaneHannanAU sorry for getting back so late. I have pushed this in 56ca0d6d1e7a2f26f6c9f26b993d37a0c44278cf. I had forgotten that the crate name becames its own feature when it's marked optional, that makes a lot of sense. Now there's only one feature, "itoa", which is disabled by default.