search

utkarshkukreti / select.rs

A Rust library to extract useful data from HTML documents, suitable for web scraping.
MIT License
959 stars 69 forks source link

Update the html5ever dependency #62

Closed nuxeh closed 4 years ago

nuxeh commented 4 years ago

This requires using the newly split-off RcDom implementation from html5ever.

Since this is now clearly marked that it shouldn't be used in production, this raises the question, should a production-ready DOM implementation be used instead for select.rs?

Razican commented 4 years ago

I think that select is in a pre-1.0 version, so it's not ready for production either. I would say it's OK to use it.

In any case, this is an important dependency upgrade for me, as I have some projects where the only reason why I'm having proc-macro2 0.4, syn 0.15 and quote 0.6 as a dependency is this missing upgrade.

Xanewok commented 4 years ago

Hey @utkarshkukreti :wave: Will you have a couple of minutes to merge this and release a new patch version with this fix?

This is a rather mechanical change and as @Razican mentioned it allows too prune <1 proc macro dependency crates which can take a substantial amount to compile (especially if someone is already using ^1.0 version of them).

Thanks for your work and thanks in advance for taking a look! 😍

utkarshkukreti commented 4 years ago

Thanks for the PR! I've released v0.5.0 with this change and some other updates.