search

utkarshkukreti / select.rs

A Rust library to extract useful data from HTML documents, suitable for web scraping.
MIT License
971 stars 69 forks source link

Implement `Debug` for `Find` #63

Closed phimuemue closed 4 years ago

phimuemue commented 4 years ago

As mentioned in https://github.com/utkarshkukreti/select.rs/issues/61, I find myself in need of a Debug implementation for Find.

The only member of Find that does not necessarily implement Debug is predicate (which may be a closure), so I left it out from the Debug impl. This is in line with Rust's Filter (and other iterators).

mainrs commented 4 years ago

Might be worth adding a

#![warn(
    missing_debug_implementations
)]

at the top of lib.rs aswell.

utkarshkukreti commented 4 years ago

Thanks for the PR! I've released v0.5.0 with this change and some other updates.