utkuerol / openlegend-discord-dicebot

An OpenLegend RPG dice bot for Discord servers
GNU General Public License v3.0
2 stars 1 forks source link

Roll Result Messages Out Of Format #1

Closed TheOGMiyagi closed 3 years ago

TheOGMiyagi commented 3 years ago

This is what the rolls look like on the Open Legend Discord Server: image

This is what the rolls look like on my server: image

Any help getting these output messages looking neater would be appreciated 😃

TheOGMiyagi commented 3 years ago

For reference, I'm using Python 3.9.2 and the current version of the code (as of commit 56acc3d1544492b88e877af36d8f8c5392b1412f )

utkuerol commented 3 years ago

Hi @TheOGMiyagi, thanks for the feedback, but unfortunately both screenshots are from different bots :D You have set up this bot in your server, but the bot on the Openlegend Server is a different bot, which has reportedly has some issues at the moment (but the developer also mentioned he was going to reimplement the whole bot soon).

What exactly would you want to see differently in my bot? My goal was to print all of the information (like dropped dice, rolled dice etc.) per default. Would you prefer a tab indentation for formatting instead of the dashes?

TheOGMiyagi commented 3 years ago

Ah, I can see why there might be different formats then! I assumed that perhaps the code from the repo was outdated compared to that on your workspace 😅

Though I will say I'm a fan of the indentation; if I could customize it, I'd probably have one piece of information per line, and use markdown text, as shown in this sample I made: image

Thank you for your hasty reply, and I must thank you for your work on this bot! 🙏 In the instance of your bot that I have running on my private servers have this command, to give credit where it's due:

elif message.content.startswith("/source code") or message.content.startswith("/src"):
        msg = "**Source Code:** https://github.com/utkuerol/openlegend-discord-dicebot"
        await message.channel.send(msg)
TheOGMiyagi commented 3 years ago

On the topic of readability, I also used Discord markdown to make the /help message more pleasing to the eye with the following changes:

> **__Openlegend Dice Commands__**
> 
> ```/roll [flags] [attribute] [advantage] [quantity]```
> ```/r [flags] [attribute] [advantage] [quantity]```    
> **Flags:**
> **-R:** Repeat the roll  
> **-V:** *Vicious Strike*: Exploding dice have advantage 
> **-D:** *Destructive Trance*: Explode on max or one less

> **__Raw Dice Commands__**
> 
> ```/!r [xdice pattern]``` 
> ```/!roll [xdice pattern]```

**xdice pattern:** Given pattern should be as described in the *xdice* documentation: https://xdice.readthedocs.io/en/latest/dice_notation.html#patterns.
Use this to roll "raw", i.e. without any Open Legend RPG specific logic.

image

I can fork the branch, if you'd like, but I thought it might be too minor a change for that.

utkuerol commented 3 years ago

That's a really good suggestion, thanks for the mockup! I will implement it as soon as possible :)

You can follow the repository to be notified of a new release with your feature implemented

utkuerol commented 3 years ago

You can just open a pull request so that I can merge it directly here

TheOGMiyagi commented 3 years ago

I made the pull request, and with that, I'll close the issue. Thank you! 😃