Closed alixinne closed 2 years ago
Thanks for the PR. It makes sense to add it, but I looked up a bit and in most public charts it is named as commonLabels
. Would it be ok if I rename it?
Sure thing, I think the other charts I was working with atm used additionalLabels but I've seen commonLabels too.
Awesome, thanks for your contribution. I just released chart version 2.3.0 with commonLabels
support.
I have started using your transmission-openvpn (works great!) but noticed it was missing a feature found in many other charts: the ability to add custom labels on the resources declared by this chart.
This PR adds support for this, under the "additionalLabels" key.