Closed fl42 closed 1 year ago
Merging #230 (65f7354) into master (7066a84) will decrease coverage by
0.14%
. The diff coverage is40.00%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 71.57% 71.43% -0.14%
==========================================
Files 24 24
Lines 1780 1782 +2
==========================================
- Hits 1274 1273 -1
- Misses 406 407 +1
- Partials 100 102 +2
Impacted Files | Coverage Δ | |
---|---|---|
internal/k8s/service.go | 70.00% <40.00%> (-6.32%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Thanks for the PR. Looks good to me. Can you please fix the linter errors? You can use task fmt
and task lint
for that (you'll need this).
Thanks, fixed :+1:
Sorry, I did the quick fix using online IDE ;)
Thanks for the contribution :)
Types of changes
AWS Load Balancer (NLB) now uses DNS-based hostname. This PR adds support to extract hostname from Kubernetes Service.