Remove helm rsync.fixPrivateKeyPerms option and change how ssh private key is mounted and used

[alex-vmw]

Remove helm rsync.fixPrivateKeyPerms option and change how ssh private key is mounted and used

Signed-off-by: Alex Romanenko <alex@vmware.com

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to change)
• [x] I have read the CONTRIBUTING document.
• [x] My code follows the code style of this project.
• [x] My change requires a change to the documentation.
• [x] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [x] All new and existing tests passed.

Testing Done

Manually tested local and lbsvc usecases.

[codecov-commenter]

Codecov Report

Merging #252 (5d68d21) into master (44e5990) will not change coverage. The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   69.56%   69.56%           
=======================================
  Files          23       23           
  Lines        1876     1876           
=======================================
  Hits         1305     1305           
  Misses        452      452           
  Partials      119      119           

Files	Coverage Δ
strategy/lbsvc.go	85.24% <100.00%> (ø)
strategy/local.go	71.12% <100.00%> (ø)
strategy/svc.go	87.75% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[utkuozdemir]

Looks cool, thank you for the work you put in. I like this solution. Pls see my comments, other than those it's all good.

[alex-vmw]

@utkuozdemir I have accepted your changes with the quotes, but the quotes actually broke ~ shell expansion, which broke the chmod command. :( I think we have 2 choices:

1. Leave ~ outside of the quotes (as in chmod 400 ~/.ssh/"$privateKeyFilename").
2. Use $HOME instead of ~ everywhere.

[utkuozdemir]

Hm, I'm wondering how the integration tests have passed... I updated the chart tgz in your branch. Integration tests should have failed.

[alex-vmw]

No idea why tests haven't failed :(, but the issue is there:

+ chmod 400 '~/.ssh/id_ed25519'
chmod: ~/.ssh/id_ed25519: No such file or directory

[alex-vmw]

I just tested a fix with chmod 400 ~/.ssh/"$privateKeyFilename" and it is working fine and can send an MR.

[utkuozdemir]

I like $HOME in quotes a bit better, feel free to submit a PR.

[alex-vmw]

OK, let me re-test with $HOME first. :)

[alex-vmw]

OK, $HOME is working (see below), so will submit the MR now.

+ mkdir -p /root/.ssh
+ chmod 700 /root/.ssh
+ cp -v /tmp/id_ed25519 /root/.ssh/
'/tmp/id_ed25519' -> '/root/.ssh/id_ed25519'
+ chmod 400 /root/.ssh/id_ed25519

[utkuozdemir]

Cool, please don't forget to do task update-chart.