fix: fix rsync retries logic (#253)

utkuozdemir / pv-migrate

CLI tool to easily migrate Kubernetes persistent volumes

Apache License 2.0

1.57k stars 76 forks source link

fix: fix rsync retries logic (#253) #256

Closed alex-vmw closed 11 months ago

alex-vmw commented 11 months ago

Signed-off-by: Alex Romanenko <alex@vmware.com

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

utkuozdemir commented 11 months ago

task update-chart is needed again :)

codecov-commenter commented 11 months ago

Codecov Report

Merging #256 (fa67ea7) into master (86e3daa) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   69.56%   69.56%           
=======================================
  Files          23       23           
  Lines        1876     1876           
=======================================
  Hits         1305     1305           
  Misses        452      452           
  Partials      119      119

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

alex-vmw commented 11 months ago

@utkuozdemir review when you have a chance and merge if all is well. Thanks.

alex-vmw commented 11 months ago

@utkuozdemir review when you have a chance and merge if all is well. Thanks.