utmgdsc / PollVotingSystem

MCS Project with Prof. Zingaro and Prof. Ilir

https://poll.utm.utoronto.ca

MIT License

6 stars 10 forks source link

Linting and Formatting for the backend #71

Closed ggggg closed 1 year ago

ggggg commented 2 years ago

Fixes

Issue #62

Proposed Changes

Adds linting to the backend
Adds linting CI using github actions

Tests

Please describe the tests that you ran to verify your changes.

[x] Compiled typescript via yarn run build to make sure no type errors are caused
[x] Ran eslint style checks

ggggg commented 2 years ago

Note: This PR is missing husky integration

hiimchrislim commented 2 years ago

If possible, could you also add in the Husky integration with this? Thanks!

ggggg commented 2 years ago

If possible, could you also add in the Husky integration with this? Thanks!

No because I cant get it to work on windows, this could be a separate issue.

shubhbapna commented 2 years ago

Husky with github desktop seems to be a known issue with some working hacks

Try: https://github.com/typicode/husky/issues/1163 https://stackoverflow.com/questions/66520423/github-desktop-husky-pre-commit-hook-does-not

hiimchrislim commented 2 years ago

No because I cant get it to work on windows, this could be a separate issue.

What errors are you encountering with Husky on Windows?

ggggg commented 2 years ago

Have a look at https://discord.com/channels/732778344466087967/1025580306926948494/1029134370671427584

shubhbapna commented 1 year ago

For next time please try to resolve such issues

You will definitely come across projects where you might not be able to setup your dev environment as smoothly. But it is definitely worth setting up your dev env correctly otherwise your PRs might be blocked until their standards are met.

But congrats on your first PR!