Closed Vladmidir closed 7 months ago
A more descriptive description would be much appreciated.
db.sequelize.sync({ force: true, logging: false}).then(async () => { // Use { force: true } cautiously as it will drop existing tables
Is using force:true just for developing/testing purpose?
you mentioned the server now runs from the root directory. is it same for the client as well? do they run concurrently ?
Also, for keyPatterns field in the JSON I am assuming that it is the key patterns related to a challenge e.g a challenge could focus on the visitor pattern or factory pattern etc.. would it be better to have a list for that field because a challenge may have several key patterns. also to keep it standardized we could have only the name of the pattern and not a description
"keyPatterns": ["Factory Method pattern for creating different types of blog posts."],
A more descriptive description would be much appreciated.
I find the code self explanatory. That said, we can discuss documentation in the next meeting.
db.sequelize.sync({ force: true, logging: false}).then(async () => { // Use { force: true } cautiously as it will drop existing tables
Is using force:true just for developing/testing purpose?
It wipes the database I am pretty sure. So if you restart the server in production with force: true
, it will delete all of people's data. Including all the solutions and user accounts.
you mentioned the server now runs from the root directory. is it same for the client as well? do they run concurrently ?
You run the server commands from the root directory. The client commands are still run from the client directory. I can explain in more details in the meeting, so that everyone is on board.
Also, for keyPatterns field in the JSON I am assuming that it is the key patterns related to a challenge e.g a challenge could focus on the visitor pattern or factory pattern etc.. would it be better to have a list for that field because a challenge may have several key patterns. also to keep it standardized we could have only the name of the pattern and not a description
"keyPatterns": ["Factory Method pattern for creating different types of blog posts."],
It is a list as of right now. We can discuss the formatting in the meeting. It is possible to add just the list of design patterns without the descriptions as an additional field.
Notes
close #22