utmsigep / member-directory

📖 Membership directory manager with API integrations.
https://utmsigep.github.io/member-directory
MIT License
27 stars 11 forks source link

Improve dependency on scheb/2fa #252

Closed scheb closed 3 years ago

scheb commented 3 years ago

Hi there, I've seen in my bundle's dependants that you're using scheb/2fa in your project. Great to see you're finding it helpful 👍

One thing that I've recognized, in your composer.json you're referencing scheb/2fa plus some sub-packages:

https://github.com/utmsigep/member-directory/blob/47a57921b2411b33acf1378af79c65c16c16650c/composer.json#L15-L17

I'd recommend not using scheb/2fa, but scheb/2fa-bundle instead. scheb/2fa is the all-in-one package which likely contains many dependencies that you don't need. And scheb/2fa includes the two sub-packages, so there's actually no need to require these when when scheb/2fa is required.