search

utokusa / OS-251

OS-251 is a synthesizer plugin
https://onsenaudio.com/products/os251
GNU General Public License v3.0
99 stars 5 forks source link

Chorus produces (undesired?) crackling noise #24

Closed CrossGridder closed 3 years ago

CrossGridder commented 3 years ago

I don't know if it was planned, but there is a crackling noise that doesn't seem to be a feature. I am attaching a preset with very few parameters turned on. Only saw is working, you can check the other 2 easily. The preset is in AU format, if you need any other format, please let me know. I couldn't find a way to save presets in a proprietary way. This is leading me to open a new REQ :). Sorry, I am giving you a lot of work :) Test1.aupreset.zip

CrossGridder commented 3 years ago

Test2.aupreset.zip Here is another example, this one is even more evident. Move the LFP Env -> Filter to appreciate the nuances.

utokusa commented 3 years ago

Thanks, I will check it.

utokusa commented 3 years ago

Let me make sure what is the crackling noise that you mentioned. I uploaded 4 wav files. Is there the noise?

exports.zip Please be careful of the volume. It may be loud because I normalized them.

If it doesn't have the noise, can you give me an example wav file and the DAW's project file?

CrossGridder commented 3 years ago

No, your files have no noise.

I was kind of dumb, it's not the oscillators, it's the chorus, always noticeable when it's on, but even more when LPF env -> filter is set between 0.4600 and 0.6300

Here's a zip file containing the project with 3 midi tracks + 3 audio tracks without Logic HPF + 3 audio tracks with Logic HPF. NoisyChorus.zip

The crackling when the builtin chorus is on is always present, with the Logic HPF turned on you can appreciate it even more.

utokusa commented 3 years ago

Thanks for detailed explanation. It is very helpful. Now I have a clear idea about what is the noise. Actually I knew the sound, but I thought it was just a trait of the chorus because I couldn't find any noise with the sin oscillator, and I didn't care much about it because I thought it was interesting. However, now, if I increase the volume, I can find the noise even with sin. So this is obviously weird because chorus is basically just a delay effect.

I've just started an investigation. Thanks.

utokusa commented 3 years ago

Hi @fedeb1979. I found out the reason. It was kind of a quantize error in the time domain. I reduced the noise by using delay-line interpolation.

It's not released yet, but you can try the fixed version from https://github.com/utokusa/OS-251/releases/tag/v_test_pr_26_chorus_noise.

This ticket was automatically closed, but feel free to ask anything :) Thanks

CrossGridder commented 3 years ago

Wonderful! I am downloading it now and let you know soon. Thanks!

CrossGridder commented 3 years ago

Yes, you fixed it, wonderful job!!!