search

utokusa / OS-251

OS-251 is a synthesizer plugin
https://onsenaudio.com/products/os251
GNU General Public License v3.0
97 stars 5 forks source link

Missing oscillator reset #33

Closed utokusa closed 2 years ago

utokusa commented 2 years ago

After finishing release in ADSR, oscillator's state should be reset. Especially smoothedShape.reset() should be called. But currently it's not.

As a result, the synth sounds with non zero shape value even shape=0 is set in some cases.

e.g.

  1. Load Key1.oapreset and play some notes.
  2. Load Key0.ospreset and you can notice that the sound is not shape=0 even it's set so.

example.zip

Even without any fix, the 'shaped' sound eventually disappears. But still it should be fixed.