utom / sketch-measure

Make it a fun to create spec for developers and teammates
http://utom.design/measure
MIT License
6.91k stars 596 forks source link

Please update for Sketch v52.1 #482

Open Huweiii opened 6 years ago

Huweiii commented 6 years ago

Please update for Sketch v52. Thank you very much!

naresh-srirangampalle commented 6 years ago

Please update. It is very difficult to work with out this plug-in.

ellunium commented 6 years ago

@Huweiii:

I gave it a try to fix it here: Fix for Sketch v52 and v52.1 - With Inspector / Mark Property (and more) working

You can get the file from the fork. Give it a try and see if it works for you: Repository (Fork) Download the zip file from the fork

I hope it helps 😊

naresh-srirangampalle commented 6 years ago

Thank you so much team.

It’s working fine.

Best Regards Naresh S


Naresh S | Sr. Visual Designer - CTIC | [24]7.ai | Mobile: +91 99860 54542 | www.247.ai

From: ellunium notifications@github.com<mailto:notifications@github.com> Reply-To: utom/sketch-measure reply@reply.github.com<mailto:reply@reply.github.com> Date: Tuesday, 9 October 2018 at 14:59 To: utom/sketch-measure sketch-measure@noreply.github.com<mailto:sketch-measure@noreply.github.com> Cc: Naresh S naresh.s@247.ai<mailto:naresh.s@247.ai>, Comment comment@noreply.github.com<mailto:comment@noreply.github.com> Subject: Re: [utom/sketch-measure] Please update for Sketch v52.1 (#482)

[24]7.aiSecurity alert : External email; unless trust the sender and/or expect this email, do not open or click links.

@Huweiiihttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Huweiii&d=DwMFaQ&c=-MJkLfNHw3fLcSxc54P8Yg&r=9lDFt0eQZdgKpfa1L0HG2A&m=H45rF57C-p-jxDoNeURWEoeZyYkRwSycK55qxo5kZLc&s=HxRh9dlN9_MGv0_wuJ3JtzUnQ_lvwnqip5itmVVwpNE&e=:

I gave it a try to fix it here: Fix for Sketch v52 and v52.1 - With Inspector / Mark Property (and more) workinghttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_utom_sketch-2Dmeasure_pull_474&d=DwMFaQ&c=-MJkLfNHw3fLcSxc54P8Yg&r=9lDFt0eQZdgKpfa1L0HG2A&m=H45rF57C-p-jxDoNeURWEoeZyYkRwSycK55qxo5kZLc&s=tjluM7vfJUK10OpDbPA-Xc8BAMG-CmUWP2NQO4ZpXrQ&e=

You can get the file from the fork. Give it a try and see if it works for you: Repository (Fork)https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ellunium_sketch-2Dmeasure&d=DwMFaQ&c=-MJkLfNHw3fLcSxc54P8Yg&r=9lDFt0eQZdgKpfa1L0HG2A&m=H45rF57C-p-jxDoNeURWEoeZyYkRwSycK55qxo5kZLc&s=y4uP6Q3IiOdUjFvOhuD4_aiMZjx1yB68OHYvzXT2JAE&e= Download the zip file from the forkhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ellunium_sketch-2Dmeasure_archive_master.zip&d=DwMFaQ&c=-MJkLfNHw3fLcSxc54P8Yg&r=9lDFt0eQZdgKpfa1L0HG2A&m=H45rF57C-p-jxDoNeURWEoeZyYkRwSycK55qxo5kZLc&s=pl5fyv8fByEJX2pZvZ6zVEY87XBJRy2ONG0sD_2dQqk&e=

I hope it helps 😊

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_utom_sketch-2Dmeasure_issues_482-23issuecomment-2D428124734&d=DwMFaQ&c=-MJkLfNHw3fLcSxc54P8Yg&r=9lDFt0eQZdgKpfa1L0HG2A&m=H45rF57C-p-jxDoNeURWEoeZyYkRwSycK55qxo5kZLc&s=77G2wAoMdfQ1ikrsPfVMB-gZi95-DymJ0iYiag0DN84&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_Ap8eIfVXeRqgicFaMT0jB5zm-2DKBqaf4Nks5ujGx8gaJpZM4XSKY-5F&d=DwMFaQ&c=-MJkLfNHw3fLcSxc54P8Yg&r=9lDFt0eQZdgKpfa1L0HG2A&m=H45rF57C-p-jxDoNeURWEoeZyYkRwSycK55qxo5kZLc&s=tRQ3TvyRyV-_NB5__8L5-iaoJ_lHY9-0yezNvWJVfEA&e=.

aptx4869zoe commented 6 years ago

@Huweiii:

I gave it a try to fix it here: Fix for Sketch v52 and v52.1 - With Inspector / Mark Property (and more) working

You can get the file from the fork. Give it a try and see if it works for you: Repository (Fork) Download the zip file from the fork

I hope it helps 😊

wow,thanks a lot, it's really helpful

luxlogica commented 6 years ago

Please note, that there are now 11 Issues that basically say the same thing: Sketch Measure is broken with the latest releases of Sketch.

Posting yet another issue saying exactly the same thing IS NOT HELPFUL. You can simply add your own experience, or frustration, by leaving a comment in one of the many existing issues.

These issues are #468, #469, #471, #472, #473, #475, #476, #477, #479, #481, and this one.

Sketch Measure developers: please review the fix (#474) from @ellunium, which might enable you to close these 11 issues at once.

kathrynl16 commented 6 years ago

I'm now getting the following error even with the latest update. screen shot 2018-10-12 at 11 55 12 am

ellunium commented 6 years ago

@kathrynl16: Thanks for reporting!

Could you please give me more details about it?

Also, if you can create a small example sketch file and put in a zip for me to test, that would be great :) By the way, did you try uninstalling, restarting sketch and reinstalling latest?

Download the latest zip file from the fork

ellunium commented 6 years ago

@kathrynl16: Could you please give it a try to the latest version?

I've added support for Library styles and a check to prevent the error you reported (https://github.com/utom/sketch-measure/pull/474/commits/65fe50b604ecc72309afb01c38674cc79fcfa8c4)

Remember to uninstall, restart sketch and install again.

Download the latest zip file from the fork

kathrynl16 commented 6 years ago

Hi @ellunium Thanks for the prompt response! I'm still getting the same issue. Might be an issue on my end. I download the update and on opening Sketch preferences from the Splash page (before opening a file) I can see version 2.7.6 is installed. However when I open a file and reopen the preferences, the version has changed to 2.7.5 and I'm getting the same error message.

ellunium commented 6 years ago

@kathrynl16 no worries :)

The reason it was changing back to 2.7.5 is because I didn't update the version for all languages. My bad :) That's fixed now (https://github.com/utom/sketch-measure/pull/474/commits/e77002b17552090f9f022a70d345134e2665108e)

Could you please git it another try? Not sure this was the problem, but maybe it helped conflict with cache.

Remember to uninstall, restart sketch and then install again.

Download the latest zip file from the fork

kathrynl16 commented 6 years ago

Hi @ellunium - The 2.7.6 is displayed the entire time but I'm still getting the same issue. Adding a sketch file that I get the issue with. Thanks for working on this! Test for Sketch Measure.sketch.zip

ellunium commented 6 years ago

@kathrynl16 I could not reproduce the error, here it exports perfectly. 😕

I tried exporting 1 page, 2 pages and everything including the symbols and everything worked.

Could you please try doing this?

Remove the PluginsWarehouse folder that lives in ~/Library/Application Support/com.bohemiancoding.sketch3/. This is where we cache plugin downloads, and if you’ve been testing different versions of your appcast, you probably have some old stuff there that’s worth cleaning.

  • Go to the Finder of Mac OS
  • From the “Go” menu navigate down to “Go to Folder” or...
  • Hit Command+Shift+G from the Mac OS X desktop or a Finder window
  • Paste the folder location ~/Library/Application Support/com.bohemiancoding.sketch3/
  • Remove/Delete the PluginsWarehouse folder

Let me know how it goes.

kathrynl16 commented 6 years ago

Hi @ellunium - still getting the same issue. I am on version 51.3 if that makes any difference

kathrynl16 commented 6 years ago

@ellunium not sure what changed but it has started working! thanks for your help!