utom / sketch-measure

Make it a fun to create spec for developers and teammates
http://utom.design/measure
MIT License
6.91k stars 596 forks source link

Spec Export Fails with Sketch 53 #536

Open pbanta81 opened 5 years ago

pbanta81 commented 5 years ago

Progress bar hangs when attempting to export an artboard containing a symbol. Suspect the updates to how overrides are handled is the culprit.

Export retains functionality when exporting artboards with no symbols.

alexandwich commented 5 years ago

@ellunium Thanks for the fixed.But I have noticed an issue with symbols.When you set a symbol as a preset. Measure will recognize it as assets. But in 53.1, measure will only recognize the main symbol as a preset.If there are more symbols inside the main symbol, it won't work.

Clear version: Measure will not export any symbol inside another symbol.

*And I noticed that if you put a slide layer inside the symbol, it will be recognize by Measure. But you have to do this to all the symbols, that's really a huge work.

Here is my sample: Example.zip

ellunium commented 5 years ago

@alexandwich I'm not sure I understand. Could you please try and illustrate what you mean?

(The best would be to have your test file exported on older sketch/measure and the newest sketch/measure so that I could compare what would be expected.)


You can get older versions of Sketch here: https://www.sketchapp.com/updates/

You can download older versions of Measure here: https://github.com/utom/sketch-measure/releases

prudat commented 5 years ago

@ellunium This latest version fixed almost all my problems. The one remaining problem I can recreate is that the export is ignored on a nested symbol that has been imported from a library.

We use this a lot with icons, which are in a shared sketch library.

to recreate

  1. Add a symbol from a library that has an export on it. (if I do a spec export now it maintains the export of the icon)

  2. Put that symbol in a document symbol.

  3. Now when I export it, I can click through the individual elements of the symbol and not access the full icon that has been marked as export.

ellunium commented 5 years ago

@prudat could you please create an example file?

prudat commented 5 years ago

I attached a zip with the sample sketch file and the spec export. I also added an image that shows what I am talking about.

problem

Export-Sketch-Measure.zip

ellunium commented 5 years ago

Thanks, I'll take a look. Maybe this also solves @alexandwich 's bug report.

jdercks commented 5 years ago

@ellunium You are AMAZING! Thank you so much for sticking through and troubleshooting this. Our company relies heavily on Sketch Measure for exporting and would have been stuck without you. Thank you, thank you!

fortinmike commented 5 years ago

@ellunium Also works for us!

@utom Please consider merging this and releasing a new official version ASAP, as it seems many are affected by this. Thanks in advance! :)

ellunium commented 5 years ago

@fortinmike The fix is not stable enough to be merged I think. :) There's still an issue with symbols, nested symbols, library symbol, etc;

Since symbols are not really into my workflow, it's taking me more time to figure what's expected against what the plugin is doing right now.

But we will get there.


@prudat I exported your file using Sketch 52 and Measure 2.7.7. Could you please take a look and let me know if that's what would you expect to happen in the latest version? Thanks in advance! :)

Export-Sketch-Measure-Sketch52-Measure2.7.7.zip


@alexandwich I exported your file using Sketch 52 and Measure 2.7.7. Could you please take a look and let me know if that's what would you expect to happen in the latest version? Thanks in advance! :)

Sample-Sketch52-Measure.2.7.7.zip

alexandwich commented 5 years ago

@ellunium Thanks! My problem is the same as @prudat . :) Here is the expected result, the nested symbol can be exported : Expected result.zip

idsampaio commented 5 years ago

@ellunium the problem came back, in Sketch version 53.2 (72643) a project with symbols and links it does not let me export. :(

ellunium commented 5 years ago

I'm on it.

This weekend I'll try to create a fix that's stable and covers all the cases, so I can make a pull request on utom's repository.

I've moved my fork by the way:

https://github.com/ellunium/sketch-measure

This fork is Aligned with utom's latest commits. I'll use it to create fixes only, applied on top of the latest commits made by utom.

https://github.com/ellunium/sketch-measure-latest

This is the fork that contains a bunch of other changes, including:

ryan-moffat commented 5 years ago

Thank you for contributing to this @ellunium Had several people on our team export your latest version and exports correctly on 53.2. The only issue that seems to be an issue for Sketch 53 is the properties panel not displaying styles for icons or components that have layer styles applied to them. Unclear how that issue has been raised but wondered if you could take a look at that also? Thank you so much!

ellunium commented 5 years ago

@ryan-moffat could you please provide me with an example file? I'll take a look.

@idsampaio @alexandwich @prudat could you please give a try to the latest changes I just pushed?

Remember to uninstall the plugin, restart sketch and install the downloaded version, just to make sure there's no cached plugin information.

Also, make sure you're using Sketch v53.2 (72643).

Download from sketch-measure-latest

Please let me know how it goes!

alexandwich commented 5 years ago

@ellunium I tested in Sketch 53.2. It worked! Thank you so much!

idsampaio commented 5 years ago

Thank you, it's working perfectly. I tested on more complex files and there was no problem. I leave here a possible functionality at a next opportunity, which is the following in the exportable files panel, we would not be able to export the image we clicked regardless of the artboard we are in. Thanks again, @ellunium for all the attention paid! captura de ecra 2019-02-25 as 10 02 32

prudat commented 5 years ago

@fortinmike The fix is not stable enough to be merged I think. :) There's still an issue with symbols, nested symbols, library symbol, etc;

Since symbols are not really into my workflow, it's taking me more time to figure what's expected against what the plugin is doing right now.

But we will get there.

@prudat I exported your file using Sketch 52 and Measure 2.7.7. Could you please take a look and let me know if that's what would you expect to happen in the latest version? Thanks in advance! :)

Export-Sketch-Measure-Sketch52-Measure2.7.7.zip

@alexandwich I exported your file using Sketch 52 and Measure 2.7.7. Could you please take a look and let me know if that's what would you expect to happen in the latest version? Thanks in advance! :)

Sample-Sketch52-Measure.2.7.7.zip

Yes that was the expected result. Sorry about the late reply, unplugged on the weekend.

ryan-moffat commented 5 years ago

@ellunium Here is the file. It exports fine with the recent release you did after my original post, yet without recgonzing layer styles. Measure won't recognize those properties. Think that you sort of addressed this but wondered if you can try this file and see where the issue lies. Here is a screenshot for reference.

screen shot 2019-02-27 at 1 16 24 pm

Sketch - Styles.zip

@ryan-moffat could you please provide me with an example file? I'll take a look.

@idsampaio @alexandwich @prudat could you please give a try to the latest changes I just pushed?

Remember to uninstall the plugin, restart sketch and install the downloaded version, just to make sure there's no cached plugin information.

Also, make sure you're using Sketch v53.2 (72643).

Download from sketch-measure-latest

Please let me know how it goes!

ellunium commented 5 years ago

@ryan-moffat interesting bug!

The problem was also (kinda) there in Sketch 52 and Measure 2.7.7, you can see the it in the exported file. Sketch - Styles-Sketch-Measure-Sketch52-Measure2.7.7.zip

The problem before (and now still) are complex/compound shapes, although before some icons would export, like the white pin. On Measure 2.7.9, the airplane icon even exports the library styles, but the map pins fail to expose their styles.

spec_export_-_sketch_measure_2_7_9

I'll take a look and see if I can fix that as well. This week I don't have much time though.

ellunium commented 5 years ago

@ryan-moffat: I've pushed a fix to the bug, could you please give it a try with that sample file and some very complex files you might have to check if the fix is close to what you expected?

Thanks in advance!


Remember to uninstall the plugin, restart sketch and install the downloaded version, just to make sure there's no cached plugin information.

Also, make sure you're using Sketch v53.2 (72643).

Download from sketch-measure-latest

Please let me know how it goes!

ryan-moffat commented 5 years ago

@ryan-moffat: I've pushed a fix to the bug, could you please give it a try with that sample file and some very complex files you might have to check if the fix is close to what you expected?

Thanks in advance!

Remember to uninstall the plugin, restart sketch and install the downloaded version, just to make sure there's no cached plugin information.

Also, make sure you're using Sketch v53.2 (72643).

Download from sketch-measure-latest

Please let me know how it goes!

You are awesome, thank you!! Works perfectly with layer and text styles with an override! Thank you so much!!! @ellunium

mitchellbernstein commented 5 years ago

Even with the latest version from sketch-measure-latest, I still couldn't export. It stopped freezing the export but instead gives a new error as seen below. I'm running Sketch 53.2 (72643). (Yes I uninstalled the old version of sketch measure, quit, and installed that particular version of sketch measure I mentioned^)

screen shot 2019-03-08 at 10 03 26 am
ellunium commented 5 years ago

@mitchellbernstein that's really strange.

Could you please share an example file that I can reproduce the bug?

Thanks in advance.

chengssir commented 5 years ago

我目前无法导出设计,因为它挂在一个特定的符号上。

截图2019-02-08 at 15 44 50

I had the same problem, right?

ellunium commented 5 years ago

@chengssir :

Sketch v53.2 (72643) is actually needed to make sure this fork (sketch-measure-latest v2.8.0) works properly.


Did you try this first?

Remember to uninstall the plugin, restart sketch and install the downloaded version, just to make sure there's no cached plugin information.

Also, make sure you're using Sketch v53.2 (72643).

Get the Fork version (v2.8.0)

Download from sketch-measure-latest

Still not working?

Follow the steps below:

Remove the PluginsWarehouse folder that lives in ~/Library/Application Support/com.bohemiancoding.sketch3/. This is where we cache plugin downloads, and if you’ve been testing different versions of your appcast, you probably have some old stuff there that’s worth cleaning.

  • Go to the Finder of Mac OS
  • From the “Go” menu navigate down to “Go to Folder” or...
  • Hit Command+Shift+G from the Mac OS X desktop or a Finder window
  • Paste the folder location ~/Library/Application Support/com.bohemiancoding.sketch3/
  • Remove/Delete the PluginsWarehouse folder

Log files

You can try to get the output of the Plugin Log:

  1. Open Utilities > Console.app
  2. Expand ~/Library/Logs in the left window, and select com.bohemiancoding.sketch3
  3. In the right window, select the file called Plugin Log.log. If this file doesn't exist, you need to get the plugin (or any plugin for that matter) to crash or to run, then the file will be created. Select the contents of the log.
  4. If you can reproduce the crash consistently, you can select the file called Plugin Log.log and select Clear in the action menu first. Run the plugin again, and only the crash information relevant to the plugin in that moment will appear. Select the contents of the log.
  5. Copy/paste the output here

Let know how it goes :)

edwardsdesign commented 5 years ago

@ellunium

I have an odd issue with SM 2.8.0 and Sketch 53 (72643).

Background: I have 2 versions of the same Sketch file that produce different outputs from SM 2.8.0. One version (3-1) was created using an icon font, the other sketch file (3-3) was duplicated from 3-1 and icon font was replaced with nested vector icons.

Issue: Sketch file 3-1 will not inspect nested symbols but Sketch file 3-3 will.

Steps to reproduce: Open SM spec export for each file and Inspect the blue and gold dialog box headers.

One thing I noticed is the spec export Assets folder does not get generated for the 3-1 file.

I have attached both sketch file versions with the SM 2.8.0 generated spec export for each. TEST 3-1_3-3.zip

tonygil74 commented 5 years ago

@pbanta81 @rayshan you can give a try to the latest found in the fork: Download latest Let me know if it works for you.

Hi @ellunium issue still exist. Any help would be appreciated. Thank you in advanced.

Screen Shot 2019-03-13 at 8 28 38 AM
ellunium commented 5 years ago

@edwardsdesign I’ll Try to take a look at this this weekend. Thanks for sharing the files, makes it easier for me to spot what’s wrong and try to fix it.

@tonygil74 did you try this ? https://github.com/utom/sketch-measure/issues/536#issuecomment-471492948

Also, could you please share with me an example file that I can reproduce the bug? Thanks in advance.

tonygil74 commented 5 years ago

@ellunium it works now!! Thanks.

ellunium commented 5 years ago

@ellunium

I have an odd issue with SM 2.8.0 and Sketch 53 (72643).

Background: I have 2 versions of the same Sketch file that produce different outputs from SM 2.8.0. One version (3-1) was created using an icon font, the other sketch file (3-3) was duplicated from 3-1 and icon font was replaced with nested vector icons.

Issue: Sketch file 3-1 will not inspect nested symbols but Sketch file 3-3 will.

Steps to reproduce: Open SM spec export for each file and Inspect the blue and gold dialog box headers.

One thing I noticed is the spec export Assets folder does not get generated for the 3-1 file.

I have attached both sketch file versions with the SM 2.8.0 generated spec export for each. TEST 3-1_3-3.zip

@edwardsdesign Which symbol are you talking about exactly?

ellunium commented 5 years ago

@ellunium

I have an odd issue with SM 2.8.0 and Sketch 53 (72643).

Background: I have 2 versions of the same Sketch file that produce different outputs from SM 2.8.0. One version (3-1) was created using an icon font, the other sketch file (3-3) was duplicated from 3-1 and icon font was replaced with nested vector icons.

Issue: Sketch file 3-1 will not inspect nested symbols but Sketch file 3-3 will.

Steps to reproduce: Open SM spec export for each file and Inspect the blue and gold dialog box headers.

One thing I noticed is the spec export Assets folder does not get generated for the 3-1 file.

I have attached both sketch file versions with the SM 2.8.0 generated spec export for each. TEST 3-1_3-3.zip

@edwardsdesign

I can inspect the info icon and the close icon, from file 3-1. I cannot inspect the info icon and the close icon, from file 3-3.

The difference between the 2 files is that:

Measure was created as such: if the layer is a slice, the code ignores the layer properties and presents the slices section, where you can access the assets within the html in the browser.

On the file 3-3, when I detach the symbol from the library, I can see that it is setup as a slice, with the resulting presets. svg, @2-png, @3-png.

image

image

image

Would this be the expected behaviour?

edwardsdesign commented 5 years ago

@ellunium

I apologize for the confusion, the issue I am having is with the nested blue/gold background color symbol in the header at the top of the dialog box, the large blue/gold rectangle area behind the info icon. File 3-1 will not recognize the nested symbol blue/gold color in the inspector but 3-3 will.

3-1 not showing blue background color in inspector: 3-1_Dialog Header_Inspect Panel

3-3 properly showing blue background color in inspector: 3-3_Dialog Header_Inspect Panel

ellunium commented 5 years ago

@edwardsdesign No worries! I’ll take a look at it, thanks for clarifying! 😋

ellunium commented 5 years ago

@edwardsdesign the reason why is because the color layers are locked, so they don't get exported.

Regular layers (not symbols) don't even get their sizes marked during export when locked, but, because these are symbol instances, Measure gets their bounding box, size and spacing, but the properties are ignored.

This could be expanded to completely ignore the layers if their symbol master contains locked layers, that would make it consistent to non-symbol instance layers in the layer list when exported, but for now, if you need those to be inspected when exporting, unlocking them will do the trick 😊

I hope this helps!

image

image

normsun commented 5 years ago

I seem to have the same export issues everyone else has, even after using the latest fork provided by @ellunium on 3/1/19.

Seems like the export gets hung up on a nested symbol, actually creates a duplicate nested symbol on my artboard, and hangs. Any thoughts?

environment info: OS v: Mojave 10.14.1 Sketch v: 53.2 SketchMeasure v: 2.8.0

ellunium commented 5 years ago

@normsun, please give this a try:

Remember to uninstall the plugin, restart sketch and install the downloaded version, just to make sure there's no cached plugin information.

Also, make sure you're using Sketch v53.2 (72643).

Get the Fork version (v2.8.0)

Download from sketch-measure-latest

Still not working?

Follow the steps below:

Remove the PluginsWarehouse folder that lives in ~/Library/Application Support/com.bohemiancoding.sketch3/. This is where we cache plugin downloads, and if you’ve been testing different versions of your appcast, you probably have some old stuff there that’s worth cleaning.

  • Go to the Finder of Mac OS
  • From the “Go” menu navigate down to “Go to Folder” or...
  • Hit Command+Shift+G from the Mac OS X desktop or a Finder window
  • Paste the folder location ~/Library/Application Support/com.bohemiancoding.sketch3/
  • Remove/Delete the PluginsWarehouse folder

Please let me know how it goes ☺️ If it still doesn’t work, please create a small sample file that I can reproduce the bug, share here and I’ll take a look. Thanks in advance!

normsun commented 5 years ago

@normsun, please give this a try:

Remember to uninstall the plugin, restart sketch and install the downloaded version, just to make sure there's no cached plugin information.

Also, make sure you're using Sketch v53.2 (72643).

Get the Fork version (v2.8.0)

Download from sketch-measure-latest

Still not working?

Follow the steps below:

  • [ ] Uninstall the plugin
  • [ ] Quit Sketch
  • [ ] Follow the steps bellow to remove the PluginsWarehouse folder
  • [ ] Download the latest zip file from the fork
  • [ ] Reinstall the plugin
  • [ ] Test the Mark Properties / Spec Export again

Remove the PluginsWarehouse folder that lives in ~/Library/Application Support/com.bohemiancoding.sketch3/. This is where we cache plugin downloads, and if you’ve been testing different versions of your appcast, you probably have some old stuff there that’s worth cleaning.

  • Go to the Finder of Mac OS
  • From the “Go” menu navigate down to “Go to Folder” or...
  • Hit Command+Shift+G from the Mac OS X desktop or a Finder window
  • Paste the folder location ~/Library/Application Support/com.bohemiancoding.sketch3/
  • Remove/Delete the PluginsWarehouse folder

Please let me know how it goes ☺️ If it still doesn’t work, please create a small sample file that I can reproduce the bug, share here and I’ll take a look. Thanks in advance!

I still had a cached version of the plug-in. It's working now. Thank you for the explicit re-install instructions @ellunium !

idsampaio commented 5 years ago

Hi, unfortunately upgrades to the sketch are great and we all like it. but the compatibility with the plugin is back in v55.2 version not letting export, it is barred in the layers / symbols. The zone of influence when we make a measurement is again great. In other words, the same errors reported in v53.2 reappear ...

drivetothegrave commented 5 years ago

@ellunium Everything works now, thank you very much!

shajeeamaan commented 5 years ago

@normsun, please give this a try:

Remember to uninstall the plugin, restart sketch and install the downloaded version, just to make sure there's no cached plugin information.

Also, make sure you're using Sketch v53.2 (72643).

Get the Fork version (v2.8.0)

Download from sketch-measure-latest

Still not working?

Follow the steps below:

  • [ ] Uninstall the plugin
  • [ ] Quit Sketch
  • [ ] Follow the steps bellow to remove the PluginsWarehouse folder
  • [ ] Download the latest zip file from the fork
  • [ ] Reinstall the plugin
  • [ ] Test the Mark Properties / Spec Export again

Remove the PluginsWarehouse folder that lives in ~/Library/Application Support/com.bohemiancoding.sketch3/. This is where we cache plugin downloads, and if you’ve been testing different versions of your appcast, you probably have some old stuff there that’s worth cleaning.

  • Go to the Finder of Mac OS
  • From the “Go” menu navigate down to “Go to Folder” or...
  • Hit Command+Shift+G from the Mac OS X desktop or a Finder window
  • Paste the folder location ~/Library/Application Support/com.bohemiancoding.sketch3/
  • Remove/Delete the PluginsWarehouse folder

Please let me know how it goes ☺️ If it still doesn’t work, please create a small sample file that I can reproduce the bug, share here and I’ll take a look. Thanks in advance!

Well I had this issue sevaral times. not always but only in some sketch files. I tried this method and it works for me (uninstall and install again) July 9 at 8.30PM