search

utopia-php / messaging

Lite & fast micro PHP messaging library that is **easy to use**.
MIT License
14 stars 62 forks source link

Feat app adapters #63

Closed abnegate closed 10 months ago

abnegate commented 11 months ago

What does this PR do?

Test Plan

Added discord test

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

eldadfux commented 10 months ago

@abnegate not sure if we should namespaces them as App adapters. What do you think about Chat?

abnegate commented 10 months ago

@abnegate not sure if we should namespaces them as App adapters. What do you think about Chat?

@eldadfux That works; just though of another option: what do you think about no nested namespace? Since they're not extending a base App/Chat adapter, it could fit better as just Utopia\Messaging\Adapter\Discord

eldadfux commented 10 months ago

@eldadfux That works; just though of another option: what do you think about no nested namespace? Since they're not extending a base App/Chat adapter, it could fit better as just Utopia\Messaging\Adapter\Discord

@abnegate I fear it will open a gateway for too much opinionated views and will start seeing to many types without a namespace which at some point could get out of hand.