utopia-rise / fmod-gdextension

FMOD Studio GDExtension bindings for the Godot game engine

MIT License

482 stars 52 forks source link

enh: In event emitter load event if any action that requires the event to be loaded is called and event not valid #254

Closed piiertho closed 1 month ago

piiertho commented 1 month ago

This is more a proposal.

In #217 we see that user has troubles to set parameters on an event that is not yet loaded.
I'm unsure how this behave is an event has done playing and someone call one of the method modified with this PR.

CedNaru commented 1 month ago

Maybe we can use that PR to fix #256 as well. The issue seems to be that changing the event property while one is playing or already preloaded has side effects. I think we need to have a bunch of different check and side effect to the property setter. On top of having methods, making sure the event property matches the fmod_event currently played.

YuriPrickles commented 1 month ago

hi, is there any update on this?

piiertho commented 1 month ago

256 will be fixed in a seperate PR.

We plan a major rework of emitters right after our talk at jetbrains gamedev days regaring godot-kotlin.