search

utopia-rise / godot-kotlin-jvm

Godot Kotlin JVM Module
MIT License
635 stars 44 forks source link

Implement JRE generation task #163

Open chippmann opened 3 years ago

chippmann commented 3 years ago

Best would be a task triggered by the Editor plugin which generates the jre when a new kotlin script is created (similar to the C# plugin) or when run is pressed but no jre is present (for the case when scripts are solely created outside the editor with Intellij for example). Also some good error messages would be nice (for example no JAVA_HOME found, JAVA <= 9 installed, and so on...).

Another possibility could be to handle this with a gradle task which get's called by the editor plugin.

Best might be to have both and execute the gradle task upon build and it checks on each build if a jre is present. So we cover the case where the godot editor is never started.

piiertho commented 3 years ago

I agree we should make it as a gradle task, this would be easier for packaging games from CI

raniejade commented 3 years ago

Can we also create a task for exporting the game? (downloading the templates automatically, etc ...) This will make supporting github actions easier.

chippmann commented 3 years ago

Indeed but i propose we create a separate issue for that as for that we'd need to implement some rest calls and the accompanying logic which blows the scope of this issue up IMO. There are already quite a few changes in my branch for this.