search

utopia-rise / godot-kotlin-jvm

Godot Kotlin JVM Module
MIT License
637 stars 46 forks source link

bugfix: embedd JRE in export app #344

Closed piiertho closed 2 years ago

piiertho commented 2 years ago

This makes difference between JRE for arm and amd systems. This fixes OSX exports by making use of Plugins app folder. Only applicable to Godot 3.5+ versions.

This resolves #266

piiertho commented 2 years ago

We need to check all exports (all os + hotspot / graal native image) before merging this

piiertho commented 2 years ago

Tested on windows for both hotspot and graal native image.

CedNaru commented 2 years ago

LGTM But reminder that at some point we should rework everything related to systems and arch as it's becoming quite messy.

piiertho commented 2 years ago

LGTM But reminder that at some point we should rework everything related to systems and arch as it's becoming quite messy.

Maybe you can write an issue so that we don't forget ?

piiertho commented 2 years ago

Tested on Android.

piiertho commented 2 years ago

Tested all exports (arm64, x86_64 and universal) for MacOS with hotspot.

piiertho commented 2 years ago

Tested on linux;

  • Editor binary without jre: OK

  • Editor binary with jre: OK

  • Release_debug export: OK

  • Release export: Ok

Found another issue: #354. But this does not need to be addressed in this PR IMO

Only issues i found are small things in the docs

I agree this should be done in another PR.