ICall crash with 5 method args limit

utopia-rise / godot-kotlin-jvm

Godot Kotlin JVM Module

MIT License

585 stars 38 forks source link

ICall crash with 5 method args limit #491

Closed chippmann closed 12 months ago

chippmann commented 1 year ago

We have a method args limit of 5 which we enforce with:

#ifdef DEBUG_ENABLED
    JVM_CRASH_COND_MSG(args_size > VARIANT_ARG_MAX, vformat("Cannot have more than %s arguments for method call.", VARIANT_ARG_MAX));
#endif

This leads to api call to fail:

ERROR: Godot-JVM: Cannot have more than 5 arguments for method call but tried to call method "ENetMultiplayerPeer::create_client" with 6 args

chippmann commented 1 year ago

It seems godot changed the max to 8 a while ago: https://github.com/godotengine/godot/pull/54188