search

utopia-rise / godot-kotlin-jvm

Godot Kotlin JVM Module
MIT License
560 stars 38 forks source link

Make jre folder platform dependent #632

Open chippmann opened 1 month ago

chippmann commented 1 month ago

This makes the jre folder platform dependent.

This makes it possible for a project to have multiple jre folder simultaneously on the file system. The module then automatically picks the correct one for the current platform. The main advantage of this is that on a project with multiple people working on it, the embedded jre can be committed to the repository for each platform together with the built jar and a project member does not need to have java locally installed and JAVA_HOME set. Which is especially useful if one is working with non programmers.

Note: Breaking change. Needs special notes in release notes!

chippmann commented 1 month ago

I tested linux editor and export templates. Could you test windows and mac? (I don't think testing on mobile is necessary but you can if you want to :-) )

chippmann commented 1 month ago

Tested the exports and editors for linux amd64 with the changes @CedNaru requested. Will test on macos later today

@piiertho need a review again from you as these were quite significant changes again

chippmann commented 1 month ago

Tested editor and export on macOS as well.

If you @CedNaru or @piiertho could test on windows, that would be appreciated.